You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/03 08:02:58 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #38492: [SPARK-38270][BUILD][FOLLOW-UP] Exclude productElementName and productElementNames in Mima for Scala 2.13
HyukjinKwon opened a new pull request, #38492:
URL: https://github.com/apache/spark/pull/38492
### What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/35594 that recovers Mima compatibility test for Scala 2.13.
### Why are the changes needed?
To fix the Mima build broken (https://github.com/apache/spark/actions/runs/3380379538/jobs/5613108397)
```
[error] spark-core: Failed binary compatibility check against org.apache.spark:spark-core_2.13:3.3.0! Found 2 potential problems (filtered 945)
[error] * method productElementName(Int)java.lang.String in object org.apache.spark.scheduler.cluster.CoarseGrainedClusterMessages#Shutdown does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.scheduler.cluster.CoarseGrainedClusterMessages#Shutdown.productElementName")
[error] * method productElementNames()scala.collection.Iterator in object org.apache.spark.scheduler.cluster.CoarseGrainedClusterMessages#Shutdown does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.scheduler.cluster.CoarseGrainedClusterMessages#Shutdown.productElementNames")
```
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
CI in this PR should test it out. After that, scheduled jobs for Scala 2.13 will test this out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38492: [SPARK-38270][BUILD][FOLLOW-UP] Exclude productElementName and productElementNames in Mima for Scala 2.13
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38492: [SPARK-38270][BUILD][FOLLOW-UP] Exclude productElementName and productElementNames in Mima for Scala 2.13
URL: https://github.com/apache/spark/pull/38492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #38492: [SPARK-38270][BUILD][FOLLOW-UP] Exclude productElementName and productElementNames in Mima for Scala 2.13
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #38492:
URL: https://github.com/apache/spark/pull/38492#issuecomment-1301909589
> We don't run Scala 2.13 build in PR builder, but only in scheduled jobs https://github.com/apache/spark/actions
Got it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #38492: [SPARK-38270][BUILD][FOLLOW-UP] Exclude productElementName and productElementNames in Mima for Scala 2.13
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #38492:
URL: https://github.com/apache/spark/pull/38492#issuecomment-1301867221
Why origin PR #35594 GA passed, what changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38492: [SPARK-38270][BUILD][FOLLOW-UP] Exclude productElementName and productElementNames in Mima for Scala 2.13
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38492:
URL: https://github.com/apache/spark/pull/38492#issuecomment-1301755303
cc @cloud-fan and @AngersZhuuuu FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38492: [SPARK-38270][BUILD][FOLLOW-UP] Exclude productElementName and productElementNames in Mima for Scala 2.13
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38492:
URL: https://github.com/apache/spark/pull/38492#issuecomment-1301892244
We don't run Scala 2.13 build in PR builder, but only in scheduled jobs https://github.com/apache/spark/actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38492: [SPARK-38270][BUILD][FOLLOW-UP] Exclude productElementName and productElementNames in Mima for Scala 2.13
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38492:
URL: https://github.com/apache/spark/pull/38492#issuecomment-1301911766
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org