You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/15 06:07:36 UTC

[GitHub] [tvm] abhikran-quic opened a new pull request, #13388: [Hexagon] Use VTCM while scheduling conv2d op

abhikran-quic opened a new pull request, #13388:
URL: https://github.com/apache/tvm/pull/13388

   cc: @csullivan @masahi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] abhikran-quic commented on pull request #13388: [Hexagon] Use VTCM while scheduling conv2d op

Posted by GitBox <gi...@apache.org>.
abhikran-quic commented on PR #13388:
URL: https://github.com/apache/tvm/pull/13388#issuecomment-1316362164

   > > to reduce tuning time
   > 
   > This test doesn't really tune anything, but does this change bring such non-trivial reduction?
   
   Yes. I saw the test execution time to come down to 25 mins instead of 40 mins.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #13388: [Hexagon] Use VTCM while scheduling conv2d op

Posted by GitBox <gi...@apache.org>.
junrushao merged PR #13388:
URL: https://github.com/apache/tvm/pull/13388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] abhikran-quic commented on a diff in pull request #13388: [Hexagon] Use VTCM while scheduling conv2d op

Posted by GitBox <gi...@apache.org>.
abhikran-quic commented on code in PR #13388:
URL: https://github.com/apache/tvm/pull/13388#discussion_r1023512424


##########
tests/python/contrib/test_hexagon/metaschedule_e2e/test_resnet50_int8.py:
##########
@@ -248,8 +248,9 @@ def index_map_nchw32c_nchw8h8w32c(n_batch, channel, height, width, channel_32):
 
         # Add cache for input and output activation layout transform,
         # note that weight is already in correct layout
-        input_cache = sch.cache_read(conv2d_block, 0, "global")  # pylint: disable=unused-variable
-        output_cache = sch.cache_write(outer_block, 0, "global")  # pylint: disable=unused-variable
+        # pylint: disable=unused-variable

Review Comment:
   This was needed only for `input_cache` and `output_cache` variables. I will move it to the top in next PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on a diff in pull request #13388: [Hexagon] Use VTCM while scheduling conv2d op

Posted by GitBox <gi...@apache.org>.
masahi commented on code in PR #13388:
URL: https://github.com/apache/tvm/pull/13388#discussion_r1023168200


##########
tests/python/contrib/test_hexagon/metaschedule_e2e/test_resnet50_int8.py:
##########
@@ -248,8 +248,9 @@ def index_map_nchw32c_nchw8h8w32c(n_batch, channel, height, width, channel_32):
 
         # Add cache for input and output activation layout transform,
         # note that weight is already in correct layout
-        input_cache = sch.cache_read(conv2d_block, 0, "global")  # pylint: disable=unused-variable
-        output_cache = sch.cache_write(outer_block, 0, "global")  # pylint: disable=unused-variable
+        # pylint: disable=unused-variable

Review Comment:
   Put this at the top of the file (see other files disabling pylint) if you need it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13388: [Hexagon] Use VTCM while scheduling conv2d op

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13388:
URL: https://github.com/apache/tvm/pull/13388#issuecomment-1314820841

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @mehrdadh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org