You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "danepitkin (via GitHub)" <gi...@apache.org> on 2023/09/15 17:01:38 UTC
[GitHub] [arrow] danepitkin opened a new pull request, #37743: GH-37742: [Python] Enable Cython 3
danepitkin opened a new pull request, #37743:
URL: https://github.com/apache/arrow/pull/37743
### Rationale for this change
Enable Cython 3.
### What changes are included in this PR?
* Unpin Cython version in builds.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes, pyarrow will build with cython 3 by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] danepitkin commented on pull request #37743: GH-37742: [Python] Enable Cython 3
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1721588833
TODO: Merge after Cython 3.0.3 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] danepitkin commented on a diff in pull request #37743: GH-37742: [Python] Enable Cython 3
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on code in PR #37743:
URL: https://github.com/apache/arrow/pull/37743#discussion_r1337575269
##########
ci/conda_env_python.txt:
##########
@@ -18,7 +18,7 @@
# don't add pandas here, because it is not a mandatory test dependency
boto3 # not a direct dependency of s3fs, but needed for our s3fs fixture
cffi
-cython<3
+cython
Review Comment:
yes, good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #37743: GH-37742: [Python] Enable Cython 3
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #37743:
URL: https://github.com/apache/arrow/pull/37743#discussion_r1337284407
##########
ci/conda_env_python.txt:
##########
@@ -18,7 +18,7 @@
# don't add pandas here, because it is not a mandatory test dependency
boto3 # not a direct dependency of s3fs, but needed for our s3fs fixture
cffi
-cython<3
+cython
Review Comment:
should we match our `setup.py` here with `cython>=0.29.31`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37743: GH-37742: [Python] Enable Cython 3
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1729788698
Revision: 834e022539cfb5c57fc00579888b44d2c349bc87
Submitted crossbow builds: [ursacomputing/crossbow @ actions-234a830b9b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-234a830b9b)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/tree/actions-234a830b9b-github-test-conda-python-3.10)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/6263621202/job/17008416825)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/6263634068/job/17008459388)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6263629607/job/17008441547)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6263629952/job/17008442848)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/6263630430/job/17008445090)|
|test-conda-python-3.10-spark-v3.4.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6263634800/job/17008461210)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/6263631640/job/17008450091)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/6263622464/job/17008421101)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6263627490/job/17008435570)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6263625607/job/17008430452)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/6263630972/job/17008446969)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6263624784/job/17008428361)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/6263628663/job/17008439142)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/6263623157/job/17008423530)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6263634140/job/17008459334)|
|test-conda-python-3.8-spark-v3.4.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6263633062/job/17008455908)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/6263621449/job/17008417709)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6263626583/job/17008432931)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6263623996/job/17008426028)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/17008459487)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/17008417856)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/17008454238)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/6263621925/job/17008419577)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] danepitkin commented on pull request #37743: GH-37742: [Python] Enable Cython 3
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1729781375
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37742: [Python] Enable Cython 3 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1751679485
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 41359dc070c63e8bfa83ca8095266e5426cc6c43.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17489762347) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37742: [Python] Enable Cython 3 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1749637195
Revision: 3d1a44f64b4a06320f10998b12347c001ec93397
Submitted crossbow builds: [ursacomputing/crossbow @ actions-354e90dcf7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-354e90dcf7)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/6424408373/job/17444993396)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/6424408825/job/17444995037)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/6424416949/job/17445019868)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6424406937/job/17444989537)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6424403847/job/17444981485)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/6424410367/job/17445001642)|
|test-conda-python-3.10-spark-v3.4.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6424411371/job/17445004341)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/6424414535/job/17445012823)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/6424404428/job/17444983508)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6424409966/job/17444999641)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6424415725/job/17445015764)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/6424404124/job/17444982357)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6424407857/job/17444991876)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/6424410884/job/17445002795)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/6424409243/job/17444996589)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6424412900/job/17445008553)|
|test-conda-python-3.8-spark-v3.4.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6424416514/job/17445018333)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/6424409628/job/17444998185)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6424413761/job/17445010954)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6424406054/job/17444987261)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/17445023488)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/17445008673)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/17445016245)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/6424403502/job/17444980632)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37743: GH-37742: [Python] Enable Cython 3
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1721587586
:warning: GitHub issue #37742 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37742: [Python] Enable Cython 3 [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1749708463
Great! Let's get this in then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37743: GH-37742: [Python] Enable Cython 3
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1736149891
Revision: a7c79460892ebfb1700e70f415f9a27002d2c6e1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8f0b65f6be](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8f0b65f6be)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/6317314441/job/17153813718)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/6317310103/job/17153799240)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/6317316759/job/17153821215)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6317319944/job/17153831899)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6317317617/job/17153824547)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/6317314991/job/17153815779)|
|test-conda-python-3.10-spark-v3.4.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6317316582/job/17153820344)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/6317317392/job/17153823921)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/6317318209/job/17153826262)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6317313248/job/17153809765)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6317312031/job/17153805760)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/6317318590/job/17153827506)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6317311326/job/17153803578)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/6317319620/job/17153831037)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/6317317184/job/17153822884)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6317309707/job/17153797971)|
|test-conda-python-3.8-spark-v3.4.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6317316947/job/17153822134)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/6317310788/job/17153801676)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6317319334/job/17153829931)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6317312599/job/17153807785)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/17153819439)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/17153813268)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/17153802537)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/6317317956/job/17153825435)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37742: [Python] Enable Cython 3 [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1749632826
Cython 3.0.3 is released! 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37742: [Python] Enable Cython 3 [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1749703366
CI failure for `test-python-cuda` is a separate issue https://github.com/apache/arrow/issues/38059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] danepitkin commented on pull request #37743: GH-37742: [Python] Enable Cython 3
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1736143959
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37742: [Python] Enable Cython 3 [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1749694419
CI failure for `test-conda-python-3.11-hypothesis` is a separate issue https://github.com/apache/arrow/issues/38057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37742: [Python] Enable Cython 3 [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #37743:
URL: https://github.com/apache/arrow/pull/37743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37742: [Python] Enable Cython 3 [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #37743:
URL: https://github.com/apache/arrow/pull/37743#issuecomment-1749633080
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org