You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/23 21:19:58 UTC
[GitHub] [pulsar] jerrypeng opened a new pull request #9689: Include pulsar-client-admin-api in the shaded version of pulsar-client-admin
jerrypeng opened a new pull request #9689:
URL: https://github.com/apache/pulsar/pull/9689
In the following PR:
https://github.com/apache/pulsar/pull/9246
The API of the pulsar-client-admin was separated into another module. However, the api module was not added to be included in the shaded version of pulsar-client-admin. This creates dependency issues such as
`java.lang.NoSuchMethodError: org.apache.pulsar.client.admin.PulsarAdminException.<init>(Lorg/apache/pulsar/shade/javax/ws/rs/ClientErrorException;)V`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng merged pull request #9689: Include pulsar-client-admin-api in the shaded version of pulsar-client-admin
Posted by GitBox <gi...@apache.org>.
jerrypeng merged pull request #9689:
URL: https://github.com/apache/pulsar/pull/9689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9689: Include pulsar-client-admin-api in the shaded version of pulsar-client-admin
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9689:
URL: https://github.com/apache/pulsar/pull/9689#issuecomment-784932111
@freeznet Can you review this? I think this is related to one task you are working on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #9689: Include pulsar-client-admin-api in the shaded version of pulsar-client-admin
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #9689:
URL: https://github.com/apache/pulsar/pull/9689#discussion_r581402677
##########
File path: pulsar-client-admin-shaded/pom.xml
##########
@@ -66,6 +66,7 @@
<include>org.apache.pulsar:pulsar-client-original</include>
<include>org.apache.pulsar:pulsar-client-api</include>
<include>org.apache.pulsar:pulsar-client-admin-original</include>
+ <include>org.apache.pulsar:pulsar-client-admin-api</include>
Review comment:
Typically, the API module should be left out of the shaded jar, instead being a transitive dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #9689: Include pulsar-client-admin-api in the shaded version of pulsar-client-admin
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #9689:
URL: https://github.com/apache/pulsar/pull/9689#discussion_r581837457
##########
File path: pulsar-client-admin-shaded/pom.xml
##########
@@ -66,6 +66,7 @@
<include>org.apache.pulsar:pulsar-client-original</include>
<include>org.apache.pulsar:pulsar-client-api</include>
<include>org.apache.pulsar:pulsar-client-admin-original</include>
+ <include>org.apache.pulsar:pulsar-client-admin-api</include>
Review comment:
I agree with @jerrypeng
we already have` org.apache.pulsar:pulsar-client-api`is it an error ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #9689: Include pulsar-client-admin-api in the shaded version of pulsar-client-admin
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #9689:
URL: https://github.com/apache/pulsar/pull/9689#discussion_r581442335
##########
File path: pulsar-client-admin-shaded/pom.xml
##########
@@ -66,6 +66,7 @@
<include>org.apache.pulsar:pulsar-client-original</include>
<include>org.apache.pulsar:pulsar-client-api</include>
<include>org.apache.pulsar:pulsar-client-admin-original</include>
+ <include>org.apache.pulsar:pulsar-client-admin-api</include>
Review comment:
@merlimat `pulsar-client-api` is included as well. The problem is with shading. If pulsar-client-admin-api is not included in the shaded JAR and is just pull in as a transitive dependency errors like
`java.lang.NoSuchMethodError: org.apache.pulsar.client.admin.PulsarAdminException.<init>(Lorg/apache/pulsar/shade/javax/ws/rs/ClientErrorException;)V`
will occur because the impl will be using the shaded version classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org