You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Ivan <xh...@gmail.com> on 2010/05/24 08:21:47 UTC

[VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Please vote for Geronimo Customized Tomcat 7.0.0.1
a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, so
current version should be a more stable one.
b. About the license issues found in the vote for Geronimo Tomcat 7.0.0.0,
as those files have been donated, so they are properly under ASL 2.0. At
this time, no files are removed explictly.
c. If the vote could be passed on time, I would like use this version in M1
branch.

 Vote will be open for 72 hours.

 [ ] +1  approve
 [ ] +0  no opinion
 [ ] -1  disapprove (and reason why)


Staging repo:

https://repository.apache.org/content/repositories/orgapachegeronimo-007/


Source repo:

https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/

-- 

I have run the servlet/JSP TCK, at least, the failed cases should not caused
by Tomcat codes itself.

The codes until rev 947397 are merged from Tomcat 7.0 trunk.

-- 
Ivan

Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Ivan <xh...@gmail.com>.
Here is my +1

2010/5/24 Ivan <xh...@gmail.com>

> Please vote for Geronimo Customized Tomcat 7.0.0.1
> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, so
> current version should be a more stable one.
> b. About the license issues found in the vote for Geronimo Tomcat 7.0.0.0,
> as those files have been donated, so they are properly under ASL 2.0. At
> this time, no files are removed explictly.
> c. If the vote could be passed on time, I would like use this version in M1
> branch.
>
>  Vote will be open for 72 hours.
>
>  [ ] +1  approve
>  [ ] +0  no opinion
>  [ ] -1  disapprove (and reason why)
>
>
> Staging repo:
>
> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
>
>
> Source repo:
>
>
> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
>
> --
>
> I have run the servlet/JSP TCK, at least, the failed cases should not
> caused by Tomcat codes itself.
>
> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
>
> --
> Ivan
>



-- 
Ivan

Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Rick McGuire <ri...@gmail.com>.
Now that the Karaf vote has completed, this component vote and getting 
the release notes completed are the only (known) remaining tasks that 
need to be completed before cutting a release candidate for Geronimo 
3.0-M1.  This is a gentle nudge for people to take a look at both.

Rick

On 5/24/2010 2:21 AM, Ivan wrote:
> Please vote for Geronimo Customized Tomcat 7.0.0.1
> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, 
> so current version should be a more stable one.
> b. About the license issues found in the vote for Geronimo Tomcat 
> 7.0.0.0, as those files have been donated, so they are properly under 
> ASL 2.0. At this time, no files are removed explictly.
> c. If the vote could be passed on time, I would like use this version 
> in M1 branch.
>
>  Vote will be open for 72 hours.
>
>  [ ] +1  approve
>  [ ] +0  no opinion
>  [ ] -1  disapprove (and reason why)
>
>
> Staging repo:
>
> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
>
>
> Source repo:
>
> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
>
> -- 
>
> I have run the servlet/JSP TCK, at least, the failed cases should not 
> caused by Tomcat codes itself.
>
> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
>
> -- 
> Ivan


Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Donald Woods <dw...@apache.org>.
+1  Build worked.  Only rat failure was for an empty file -
catalina/src/main/resources/org/apache/ServerInfo.properties


-Donald


On 5/24/10 2:21 AM, Ivan wrote:
> Please vote for Geronimo Customized Tomcat 7.0.0.1
> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, so
> current version should be a more stable one.
> b. About the license issues found in the vote for Geronimo Tomcat
> 7.0.0.0, as those files have been donated, so they are properly under
> ASL 2.0. At this time, no files are removed explictly.
> c. If the vote could be passed on time, I would like use this version in
> M1 branch.
> 
>  Vote will be open for 72 hours.
> 
>  [ ] +1  approve
>  [ ] +0  no opinion
>  [ ] -1  disapprove (and reason why)
> 
> 
> Staging repo:
> 
> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
> 
> 
> Source repo:
> 
> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
> 
> -- 
> 
> I have run the servlet/JSP TCK, at least, the failed cases should not
> caused by Tomcat codes itself.
> 
> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
> 
> -- 
> Ivan

[RESULT][VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Ivan <xh...@gmail.com>.
OK, thanks, everyone, finally, we pass this vote, I will promote the
artifacts soon !
+1 : Rick McGuire, Donald Woods, Joe Bohn

2010/6/2 Ivan <xh...@gmail.com>

> OK, thanks for clarifying it, Kevan
> I will wait to tomorrow, if no objection, I hope to pass this long time
> vote.
>
> 2010/6/2 Kevan Miller <ke...@gmail.com>
>
>>
>> On Jun 1, 2010, at 9:09 PM, Ivan wrote:
>>
>> I checked the Tomcat's own NOTICE files, we do not distribute those
>> components in the customized Tomcat release.
>>
>> Quoted from NOTICE file :
>>
>> The Windows Installer is built with the Nullsoft Scriptable Install System
>> (NSIS), which is open source software. The original software and related
>> information is available at http://nsis.sourceforge.net.
>> Java compilation software for JSP pages is provided by Eclipse, which is
>> open source software. The original software and related information is
>> available at http://www.eclipse.org. For the bayeux implementation
>> The org.apache.cometd.bayeux API is derivative work originating at the
>> Dojo Foundation * Copyright 2007-2008 Guy Molinari * Copyright 2007-2008
>> Filip Hanik * Copyright 2007 Dojo Foundation * Copyright 2007 Mort Bay
>> Consulting Pty. Ltd.
>> The original XML Schemas for Java EE Deployment Descriptors: -
>> javaee_5.xsd - javaee_web_services_1_2.xsd -
>> javaee_web_services_client_1_2.xsd - javaee_6.xsd -
>> javaee_web_services_1_3.xsd - javaee_web_services_client_1_3.xsd -
>> web-app_3_0.xsd - web-common_3_0.xsd - web-fragment_3_0.xsd - jsp_2_2.xsd
>> may be obtained from http://java.sun.com/xml/ns/javaee/
>>
>> In the LICENSE file, I found other licenses except for ASL in the
>> following :
>> 1.  Eclipse Public License - v 1.0
>> 2. zlib/libpng license.
>> 3. bzip2 license.
>> 4. Common Public License version 1.0.
>> 5. COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
>>
>> All those licenses are for Tomcat sub components.
>>
>> I am not quite familiar those license issues, but since we do not
>> distribute those components, we should not require to add them.
>> Comments ?
>>
>>
>> As long as the LICENSE/NOTICE information do not cover any of the
>> source/binaries that we are releasing, then that sounds correct.
>>
>> --kevan
>>
>>
>
>
> --
> Ivan
>



-- 
Ivan

Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Ivan <xh...@gmail.com>.
OK, thanks for clarifying it, Kevan
I will wait to tomorrow, if no objection, I hope to pass this long time
vote.

2010/6/2 Kevan Miller <ke...@gmail.com>

>
> On Jun 1, 2010, at 9:09 PM, Ivan wrote:
>
> I checked the Tomcat's own NOTICE files, we do not distribute those
> components in the customized Tomcat release.
>
> Quoted from NOTICE file :
>
> The Windows Installer is built with the Nullsoft Scriptable Install System
> (NSIS), which is open source software. The original software and related
> information is available at http://nsis.sourceforge.net.
> Java compilation software for JSP pages is provided by Eclipse, which is
> open source software. The original software and related information is
> available at http://www.eclipse.org. For the bayeux implementation
> The org.apache.cometd.bayeux API is derivative work originating at the Dojo
> Foundation * Copyright 2007-2008 Guy Molinari * Copyright 2007-2008 Filip
> Hanik * Copyright 2007 Dojo Foundation * Copyright 2007 Mort Bay Consulting
> Pty. Ltd.
> The original XML Schemas for Java EE Deployment Descriptors: - javaee_5.xsd
> - javaee_web_services_1_2.xsd - javaee_web_services_client_1_2.xsd -
> javaee_6.xsd - javaee_web_services_1_3.xsd -
> javaee_web_services_client_1_3.xsd - web-app_3_0.xsd - web-common_3_0.xsd -
> web-fragment_3_0.xsd - jsp_2_2.xsd may be obtained from
> http://java.sun.com/xml/ns/javaee/
>
> In the LICENSE file, I found other licenses except for ASL in the following
> :
> 1.  Eclipse Public License - v 1.0
> 2. zlib/libpng license.
> 3. bzip2 license.
> 4. Common Public License version 1.0.
> 5. COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
>
> All those licenses are for Tomcat sub components.
>
> I am not quite familiar those license issues, but since we do not
> distribute those components, we should not require to add them.
> Comments ?
>
>
> As long as the LICENSE/NOTICE information do not cover any of the
> source/binaries that we are releasing, then that sounds correct.
>
> --kevan
>
>


-- 
Ivan

Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Kevan Miller <ke...@gmail.com>.
On Jun 1, 2010, at 9:09 PM, Ivan wrote:

> I checked the Tomcat's own NOTICE files, we do not distribute those components in the customized Tomcat release.
> 
> Quoted from NOTICE file :
> 
> The Windows Installer is built with the Nullsoft Scriptable Install System (NSIS), which is open source software. The original software and related information is available at http://nsis.sourceforge.net. 
> Java compilation software for JSP pages is provided by Eclipse, which is open source software. The original software and related information is available at http://www.eclipse.org. For the bayeux implementation 
> The org.apache.cometd.bayeux API is derivative work originating at the Dojo Foundation * Copyright 2007-2008 Guy Molinari * Copyright 2007-2008 Filip Hanik * Copyright 2007 Dojo Foundation * Copyright 2007 Mort Bay Consulting Pty. Ltd. 
> The original XML Schemas for Java EE Deployment Descriptors: - javaee_5.xsd - javaee_web_services_1_2.xsd - javaee_web_services_client_1_2.xsd - javaee_6.xsd - javaee_web_services_1_3.xsd - javaee_web_services_client_1_3.xsd - web-app_3_0.xsd - web-common_3_0.xsd - web-fragment_3_0.xsd - jsp_2_2.xsd may be obtained from http://java.sun.com/xml/ns/javaee/ 
> 
> In the LICENSE file, I found other licenses except for ASL in the following :
> 1.  Eclipse Public License - v 1.0 
> 2. zlib/libpng license. 
> 3. bzip2 license.
> 4. Common Public License version 1.0. 
> 5. COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0 
> 
> All those licenses are for Tomcat sub components.
> 
> I am not quite familiar those license issues, but since we do not distribute those components, we should not require to add them.
> Comments ?

As long as the LICENSE/NOTICE information do not cover any of the source/binaries that we are releasing, then that sounds correct.

--kevan


Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Ivan <xh...@gmail.com>.
I checked the Tomcat's own NOTICE files, we do not distribute those
components in the customized Tomcat release.

Quoted from NOTICE file :

The Windows Installer is built with the Nullsoft Scriptable Install System
(NSIS), which is open source software. The original software and related
information is available at http://nsis.sourceforge.net.
Java compilation software for JSP pages is provided by Eclipse, which is
open source software. The original software and related information is
available at http://www.eclipse.org. For the bayeux implementation
The org.apache.cometd.bayeux API is derivative work originating at the Dojo
Foundation * Copyright 2007-2008 Guy Molinari * Copyright 2007-2008 Filip
Hanik * Copyright 2007 Dojo Foundation * Copyright 2007 Mort Bay Consulting
Pty. Ltd.
The original XML Schemas for Java EE Deployment Descriptors: - javaee_5.xsd
- javaee_web_services_1_2.xsd - javaee_web_services_client_1_2.xsd -
javaee_6.xsd - javaee_web_services_1_3.xsd -
javaee_web_services_client_1_3.xsd - web-app_3_0.xsd - web-common_3_0.xsd -
web-fragment_3_0.xsd - jsp_2_2.xsd may be obtained from
http://java.sun.com/xml/ns/javaee/

In the LICENSE file, I found other licenses except for ASL in the following
:
1.  Eclipse Public License - v 1.0
2. zlib/libpng license.
3. bzip2 license.
4. Common Public License version 1.0.
5. COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0

All those licenses are for Tomcat sub components.

I am not quite familiar those license issues, but since we do not distribute
those components, we should not require to add them.
Comments ?


2010/6/2 Kevan Miller <ke...@gmail.com>

> How were the LICENSE and NOTICE files built? They seem to be generic...
> However, the original Tomcat license/notice files have multiple licenses and
> notice information...
>
> --kevan
>
> On May 24, 2010, at 2:21 AM, Ivan wrote:
>
> Please vote for Geronimo Customized Tomcat 7.0.0.1
> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, so
> current version should be a more stable one.
> b. About the license issues found in the vote for Geronimo Tomcat 7.0.0.0,
> as those files have been donated, so they are properly under ASL 2.0. At
> this time, no files are removed explictly.
> c. If the vote could be passed on time, I would like use this version in M1
> branch.
>
>  Vote will be open for 72 hours.
>
>  [ ] +1  approve
>  [ ] +0  no opinion
>  [ ] -1  disapprove (and reason why)
>
>
> Staging repo:
>
> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
>
>
> Source repo:
>
>
> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
>
> --
>
> I have run the servlet/JSP TCK, at least, the failed cases should not
> caused by Tomcat codes itself.
>
> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
>
> --
> Ivan
>
>
>


-- 
Ivan

Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Kevan Miller <ke...@gmail.com>.
How were the LICENSE and NOTICE files built? They seem to be generic... However, the original Tomcat license/notice files have multiple licenses and notice information...

--kevan
On May 24, 2010, at 2:21 AM, Ivan wrote:

> Please vote for Geronimo Customized Tomcat 7.0.0.1
> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, so current version should be a more stable one.
> b. About the license issues found in the vote for Geronimo Tomcat 7.0.0.0, as those files have been donated, so they are properly under ASL 2.0. At this time, no files are removed explictly.
> c. If the vote could be passed on time, I would like use this version in M1 branch.
> 
>  Vote will be open for 72 hours.
> 
>  [ ] +1  approve
>  [ ] +0  no opinion
>  [ ] -1  disapprove (and reason why)
> 
> 
> Staging repo:
> 
> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
> 
> 
> Source repo:
> 
> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
> 
> -- 
> 
> I have run the servlet/JSP TCK, at least, the failed cases should not caused by Tomcat codes itself.
> 
> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
> 
> -- 
> Ivan


Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Rick McGuire <ri...@gmail.com>.
Ok, time for a slightly less gentle reminder.  This component is the 
last item that needs to be resolved before cutting the Geronimo 3.0-M1 
release.  I think we need a couple more votes to wrap this up.  Please 
take the time to give this some attention.

Rick

On 5/24/2010 2:21 AM, Ivan wrote:
> Please vote for Geronimo Customized Tomcat 7.0.0.1
> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, 
> so current version should be a more stable one.
> b. About the license issues found in the vote for Geronimo Tomcat 
> 7.0.0.0, as those files have been donated, so they are properly under 
> ASL 2.0. At this time, no files are removed explictly.
> c. If the vote could be passed on time, I would like use this version 
> in M1 branch.
>
>  Vote will be open for 72 hours.
>
>  [ ] +1  approve
>  [ ] +0  no opinion
>  [ ] -1  disapprove (and reason why)
>
>
> Staging repo:
>
> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
>
>
> Source repo:
>
> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
>
> -- 
>
> I have run the servlet/JSP TCK, at least, the failed cases should not 
> caused by Tomcat codes itself.
>
> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
>
> -- 
> Ivan


Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Joe Bohn <jo...@earthlink.net>.
I tend to agree that this shouldn't be a big deal or require a respin. 
However, I don't know the purpose of these serverinfo properties and so 
I raised the concern to gather other feedback.

If we assume that the values are only used for information/display 
purposes (which might not even be exposed within Geronimo) then there is 
no reason for a respin.

Here is my +1 with the assumption that these are "info only" fields and 
won't cause any real problems or confusion.

Joe


On 6/1/10 7:52 AM, Rick McGuire wrote:
> On 6/1/2010 7:38 AM, Ivan wrote:
>> However if there is still time, I am not objecting to rollback this
>> vote ......
>
> I do object. Rolling this back will push out starting the Geronimo
> 3.0-M1 another 3 days. If this is not a critical problem, I don't think
> the vote should be restarted for this.
>
> Rick
>
>
>


Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Rick McGuire <ri...@gmail.com>.
On 6/1/2010 7:38 AM, Ivan wrote:
> However if there is still time, I am not objecting to rollback this 
> vote ......

I do object.  Rolling this back will push out starting the Geronimo
3.0-M1 another 3 days.  If this is not a critical problem, I don't think
the vote should be restarted for this.

Rick



Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Ivan <xh...@gmail.com>.
However if there is still time, I am not objecting to rollback this vote
......

2010/6/1 Ivan <xh...@gmail.com>

> Yes, I think it is replaced by tomcat-archetype while creating the Tomcat
> project, in the last release, I guess that I manually recovered those values
> to ${version}.
> Personally, I think it is acceptable, the values in the property files
> would show on the page while some errors are occured.
>
> 2010/6/1 Joe Bohn <jo...@earthlink.net>
>
>
>> I took a look.  The only unusual thing that I noticed was a reference to
>> the SNAPSHOT version still (7.0.0.1-SNAPSHOT) in catalina.  But I'm not sure
>> how critical this is.
>>
>> It is in the catalina jar pom.xml and ServerInfo.properties and is
>> actually set in the ServerInfo.properties as a result of the pom entry.  So,
>> IIUC, we should have changed the catalina/pom.xml prior to the release for
>> 7.0.0.1.   It looks like this wasn't a problem in 7.0.0.0 because it used
>> ${version} which would have been a better solution. Does anybody know the
>> significance of this?
>>
>> Joe
>>
>>
>>
>>
>> On 5/24/10 2:21 AM, Ivan wrote:
>>
>>> Please vote for Geronimo Customized Tomcat 7.0.0.1
>>> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, so
>>> current version should be a more stable one.
>>> b. About the license issues found in the vote for Geronimo Tomcat
>>> 7.0.0.0, as those files have been donated, so they are properly under
>>> ASL 2.0. At this time, no files are removed explictly.
>>> c. If the vote could be passed on time, I would like use this version in
>>> M1 branch.
>>>
>>>  Vote will be open for 72 hours.
>>>
>>>  [ ] +1  approve
>>>  [ ] +0  no opinion
>>>  [ ] -1  disapprove (and reason why)
>>>
>>>
>>> Staging repo:
>>>
>>> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
>>>
>>>
>>> Source repo:
>>>
>>>
>>> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
>>>
>>> --
>>>
>>> I have run the servlet/JSP TCK, at least, the failed cases should not
>>> caused by Tomcat codes itself.
>>>
>>> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
>>>
>>> --
>>> Ivan
>>>
>>
>>
>
>
> --
> Ivan
>



-- 
Ivan

Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Ivan <xh...@gmail.com>.
Yes, I think it is replaced by tomcat-archetype while creating the Tomcat
project, in the last release, I guess that I manually recovered those values
to ${version}.
Personally, I think it is acceptable, the values in the property files would
show on the page while some errors are occured.

2010/6/1 Joe Bohn <jo...@earthlink.net>

>
> I took a look.  The only unusual thing that I noticed was a reference to
> the SNAPSHOT version still (7.0.0.1-SNAPSHOT) in catalina.  But I'm not sure
> how critical this is.
>
> It is in the catalina jar pom.xml and ServerInfo.properties and is actually
> set in the ServerInfo.properties as a result of the pom entry.  So, IIUC, we
> should have changed the catalina/pom.xml prior to the release for 7.0.0.1.
> It looks like this wasn't a problem in 7.0.0.0 because it used ${version}
> which would have been a better solution. Does anybody know the significance
> of this?
>
> Joe
>
>
>
>
> On 5/24/10 2:21 AM, Ivan wrote:
>
>> Please vote for Geronimo Customized Tomcat 7.0.0.1
>> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, so
>> current version should be a more stable one.
>> b. About the license issues found in the vote for Geronimo Tomcat
>> 7.0.0.0, as those files have been donated, so they are properly under
>> ASL 2.0. At this time, no files are removed explictly.
>> c. If the vote could be passed on time, I would like use this version in
>> M1 branch.
>>
>>  Vote will be open for 72 hours.
>>
>>  [ ] +1  approve
>>  [ ] +0  no opinion
>>  [ ] -1  disapprove (and reason why)
>>
>>
>> Staging repo:
>>
>> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
>>
>>
>> Source repo:
>>
>>
>> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
>>
>> --
>>
>> I have run the servlet/JSP TCK, at least, the failed cases should not
>> caused by Tomcat codes itself.
>>
>> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
>>
>> --
>> Ivan
>>
>
>


-- 
Ivan

Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Joe Bohn <jo...@earthlink.net>.
I took a look.  The only unusual thing that I noticed was a reference to 
the SNAPSHOT version still (7.0.0.1-SNAPSHOT) in catalina.  But I'm not 
sure how critical this is.

It is in the catalina jar pom.xml and ServerInfo.properties and is 
actually set in the ServerInfo.properties as a result of the pom entry. 
  So, IIUC, we should have changed the catalina/pom.xml prior to the 
release for 7.0.0.1.   It looks like this wasn't a problem in 7.0.0.0 
because it used ${version} which would have been a better solution. 
Does anybody know the significance of this?

Joe



On 5/24/10 2:21 AM, Ivan wrote:
> Please vote for Geronimo Customized Tomcat 7.0.0.1
> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, so
> current version should be a more stable one.
> b. About the license issues found in the vote for Geronimo Tomcat
> 7.0.0.0, as those files have been donated, so they are properly under
> ASL 2.0. At this time, no files are removed explictly.
> c. If the vote could be passed on time, I would like use this version in
> M1 branch.
>
>   Vote will be open for 72 hours.
>
>   [ ] +1  approve
>   [ ] +0  no opinion
>   [ ] -1  disapprove (and reason why)
>
>
> Staging repo:
>
> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
>
>
> Source repo:
>
> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
>
> --
>
> I have run the servlet/JSP TCK, at least, the failed cases should not
> caused by Tomcat codes itself.
>
> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
>
> --
> Ivan


Re: [VOTE] Release Geronimo Customized Tomcat 7.0.0.1

Posted by Rick McGuire <ri...@gmail.com>.
=1

This looks much cleaner than the 7.0.0.0 version.

Rick

On 5/24/2010 2:21 AM, Ivan wrote:
> Please vote for Geronimo Customized Tomcat 7.0.0.1
> a. Recently, Tomcat community has begun their vote for Tomcat 7 RC 3, 
> so current version should be a more stable one.
> b. About the license issues found in the vote for Geronimo Tomcat 
> 7.0.0.0, as those files have been donated, so they are properly under 
> ASL 2.0. At this time, no files are removed explictly.
> c. If the vote could be passed on time, I would like use this version 
> in M1 branch.
>
>  Vote will be open for 72 hours.
>
>  [ ] +1  approve
>  [ ] +0  no opinion
>  [ ] -1  disapprove (and reason why)
>
>
> Staging repo:
>
> https://repository.apache.org/content/repositories/orgapachegeronimo-007/
>
>
> Source repo:
>
> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.1/
>
> -- 
>
> I have run the servlet/JSP TCK, at least, the failed cases should not 
> caused by Tomcat codes itself.
>
> The codes until rev 947397 are merged from Tomcat 7.0 trunk.
>
> -- 
> Ivan