You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by brosander <gi...@git.apache.org> on 2017/03/08 23:01:58 UTC

[GitHub] nifi pull request #1578: NIFI-3574 - PutHiveStreaming UGI fixes

GitHub user brosander opened a pull request:

    https://github.com/apache/nifi/pull/1578

    NIFI-3574 - PutHiveStreaming UGI fixes

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [X] - N/A - If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [X] - N/A - If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [X] - N/A - If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [X] - N/A - If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [X] - N/A - Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi NIFI-3574

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1578.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1578
    
----
commit 095a235075d2676d870b63dcba5b35507d9f45e7
Author: Bryan Rosander <br...@apache.org>
Date:   2017-03-08T22:41:59Z

    NIFI-3574 - PutHiveStreaming UGI fixes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1578: NIFI-3574 - PutHiveStreaming UGI fixes

Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1578#discussion_r105418460
  
    --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveConfigurator.java ---
    @@ -74,7 +74,8 @@ public HiveConf getConfigurationFromFiles(final String configFiles) {
     
         public void preload(Configuration configuration) {
             try {
    -            FileSystem.get(configuration);
    +            FileSystem.get(configuration).close();
    --- End diff --
    
    Hey @mattyb149 
    
    The two clusters I was testing against (secure and unsecure) were both configured for HA so I did test preloading with HA inadvertently :smile:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1578: NIFI-3574 - PutHiveStreaming UGI fixes

Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/1578
  
    +1 LGTM, ran unit tests and contrib-check, thank you for the fix! Merging to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1578: NIFI-3574 - PutHiveStreaming UGI fixes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1578


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1578: NIFI-3574 - PutHiveStreaming UGI fixes

Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:

    https://github.com/apache/nifi/pull/1578
  
    contrib-check build working on linux, from root nifi folder, on OSX I've been having issues with kafka tests so I just ran the changed modules and those are checking out


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1578: NIFI-3574 - PutHiveStreaming UGI fixes

Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1578#discussion_r105409335
  
    --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveConfigurator.java ---
    @@ -74,7 +74,8 @@ public HiveConf getConfigurationFromFiles(final String configFiles) {
     
         public void preload(Configuration configuration) {
             try {
    -            FileSystem.get(configuration);
    +            FileSystem.get(configuration).close();
    --- End diff --
    
    Did you test this with respect to why this line was added in the first place (High Availability clusters I think)? Just wanted to make sure it wouldn't introduce a regression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---