You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2013/03/13 21:15:55 UTC
RE: svn commit: r1456054 - in /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp src/org/apache/subversion/javahl/types/Status.java tests/org/apache/subversion/javahl/BasicTests.java
> -----Original Message-----
> From: philip@apache.org [mailto:philip@apache.org]
> Sent: woensdag 13 maart 2013 18:25
> To: commits@subversion.apache.org
> Subject: svn commit: r1456054 - in
> /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp
> src/org/apache/subversion/javahl/types/Status.java
> tests/org/apache/subversion/javahl/BasicTests.java
>
> Author: philip
> Date: Wed Mar 13 17:24:44 2013
> New Revision: 1456054
>
> URL: http://svn.apache.org/r1456054
> Log:
> Update JavaHL to provide moved_from and moved_to in status.
>
> [In subversion/bindings/javahl]
>
> * native/CreateJ.cpp
> (CreateJ::Status): Adjust method signature, pass new parameters.
>
> * src/org/apache/subversion/javahl/types/Status.java
> (Status): Add new members.
> (Status.Status): Add new parameters.
> (Status.getMovedFromAbspath, Status.getMovedToAbspath): New.
>
> * tests/org/apache/subversion/javahl/BasicTests.java
> (BasicTests.testMove): Test moved_from and moved_to in status.
Setting environment for using Microsoft Visual Studio 2008 x86 tools.
Testing Debug configuration on local repository.
Running org.apache.subversion tests:
.........................F................
................
Time: 15,916
There was 1 failure:
1) testMove(org.apache.subversion.javahl.BasicTests)junit.framework.ComparisonFailure: null expected:<null> but was:<E:\w2k3\tests\javahl\working_copies\basic_test20\A\B/E/beta>
at org.apache.subversion.javahl.BasicTests.testMove(BasicTests.java:1046)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at org.apache.subversion.javahl.RunTests.main(RunTests.java:116)
And that path neither looks like a correct Windows path, nor a Subversion canonical path.
Bert
Re: svn commit: r1456054 - in /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp src/org/apache/subversion/javahl/types/Status.java tests/org/apache/subversion/javahl/BasicTests.java
Posted by Philip Martin <ph...@wandisco.com>.
"Bert Huijben" <be...@qqmail.nl> writes:
>> -----Original Message-----
>> From: philip@apache.org [mailto:philip@apache.org]
>> Sent: woensdag 13 maart 2013 18:25
>> To: commits@subversion.apache.org
>> Subject: svn commit: r1456054 - in
>> /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp
>> src/org/apache/subversion/javahl/types/Status.java
>> tests/org/apache/subversion/javahl/BasicTests.java
>>
>> Author: philip
>> Date: Wed Mar 13 17:24:44 2013
>> New Revision: 1456054
>>
>> URL: http://svn.apache.org/r1456054
>> Log:
>> Update JavaHL to provide moved_from and moved_to in status.
>>
>> [In subversion/bindings/javahl]
>>
>> * native/CreateJ.cpp
>> (CreateJ::Status): Adjust method signature, pass new parameters.
>>
>> * src/org/apache/subversion/javahl/types/Status.java
>> (Status): Add new members.
>> (Status.Status): Add new parameters.
>> (Status.getMovedFromAbspath, Status.getMovedToAbspath): New.
>>
>> * tests/org/apache/subversion/javahl/BasicTests.java
>> (BasicTests.testMove): Test moved_from and moved_to in status.
>
>
> Setting environment for using Microsoft Visual Studio 2008 x86 tools.
> Testing Debug configuration on local repository.
> Running org.apache.subversion tests:
> .........................F................
> ................
> Time: 15,916
> There was 1 failure:
> 1) testMove(org.apache.subversion.javahl.BasicTests)junit.framework.ComparisonFailure: null expected:<null> but was:<E:\w2k3\tests\javahl\working_copies\basic_test20\A\B/E/beta>
> at org.apache.subversion.javahl.BasicTests.testMove(BasicTests.java:1046)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at org.apache.subversion.javahl.RunTests.main(RunTests.java:116)
>
>
> And that path neither looks like a correct Windows path, nor a Subversion canonical path.
I can't work out from the existing tests how I should be constructing
canonical paths.
new File(thisTest.getWorkingCopy(), "A/B").getPath();
thisTest.getWCPath() + "/A/B";
fileToSVNPath(new File(statusPath + "/E/alpha"), false)
fileToSVNPath(new File(statusPath + "/E/alpha"), true)
Something else altogether?
Do the JavaHL bindings provide a wraped version of the core
canonicalisation functions?
--
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Re: svn commit: r1456054 - in /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp src/org/apache/subversion/javahl/types/Status.java tests/org/apache/subversion/javahl/BasicTests.java
Posted by Philip Martin <ph...@wandisco.com>.
"Bert Huijben" <be...@qqmail.nl> writes:
>> -----Original Message-----
>> From: philip@apache.org [mailto:philip@apache.org]
>> Sent: woensdag 13 maart 2013 18:25
>> To: commits@subversion.apache.org
>> Subject: svn commit: r1456054 - in
>> /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp
>> src/org/apache/subversion/javahl/types/Status.java
>> tests/org/apache/subversion/javahl/BasicTests.java
>>
>> Author: philip
>> Date: Wed Mar 13 17:24:44 2013
>> New Revision: 1456054
>>
>> URL: http://svn.apache.org/r1456054
>> Log:
>> Update JavaHL to provide moved_from and moved_to in status.
>>
>> [In subversion/bindings/javahl]
>>
>> * native/CreateJ.cpp
>> (CreateJ::Status): Adjust method signature, pass new parameters.
>>
>> * src/org/apache/subversion/javahl/types/Status.java
>> (Status): Add new members.
>> (Status.Status): Add new parameters.
>> (Status.getMovedFromAbspath, Status.getMovedToAbspath): New.
>>
>> * tests/org/apache/subversion/javahl/BasicTests.java
>> (BasicTests.testMove): Test moved_from and moved_to in status.
>
>
> Setting environment for using Microsoft Visual Studio 2008 x86 tools.
> Testing Debug configuration on local repository.
> Running org.apache.subversion tests:
> .........................F................
> ................
> Time: 15,916
> There was 1 failure:
> 1) testMove(org.apache.subversion.javahl.BasicTests)junit.framework.ComparisonFailure: null expected:<null> but was:<E:\w2k3\tests\javahl\working_copies\basic_test20\A\B/E/beta>
> at org.apache.subversion.javahl.BasicTests.testMove(BasicTests.java:1046)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at org.apache.subversion.javahl.RunTests.main(RunTests.java:116)
>
>
> And that path neither looks like a correct Windows path, nor a Subversion canonical path.
I can't work out from the existing tests how I should be constructing
canonical paths.
new File(thisTest.getWorkingCopy(), "A/B").getPath();
thisTest.getWCPath() + "/A/B";
fileToSVNPath(new File(statusPath + "/E/alpha"), false)
fileToSVNPath(new File(statusPath + "/E/alpha"), true)
Something else altogether?
Do the JavaHL bindings provide a wraped version of the core
canonicalisation functions?
--
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download