You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by vrozkovec <gi...@git.apache.org> on 2018/05/04 16:34:39 UTC

[GitHub] wicket pull request #278: Changed order of elements in the DataTable's HTML

GitHub user vrozkovec opened a pull request:

    https://github.com/apache/wicket/pull/278

    Changed order of elements in the DataTable's HTML

    It should not matter, but it does for example when generating PDFs with wkhtmltopdf tool - table footer gets displayed at the top, this change fixes that.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vrozkovec/wicket master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #278
    
----
commit 695896e8984ff56c6bbe3612eb9ddd95da45c6d5
Author: Vít Rozkovec <vi...@...>
Date:   2018-05-04T16:32:15Z

    Changed order of elements in the DataTable's HTML
    
    It should not matter, but it does for example when generating PDFs with wkhtmltopdf tool - table footer gets displayed at the top, this change fixes that.

----


---

[GitHub] wicket pull request #278: Changed order of elements in the DataTable's HTML

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/wicket/pull/278


---

[GitHub] wicket issue #278: Changed order of elements in the DataTable's HTML

Posted by svenmeier <gi...@git.apache.org>.

Github user svenmeier commented on the issue:

    https://github.com/apache/wicket/pull/278
  
    IIRC the current ordering (<thead><tfoot><tbody>) was chosen deliberately to conform to the HTML standard, but it seems this has changed with HTML5:
    
    https://stackoverflow.com/questions/18901950/thead-tfoot-and-tbody-order-in-html5?rq=1
    
    So we might choose to change the default markup, please open an issue and/or a discussion/vote for this. For now you can just use your custom markup in a custom subclass.


---