You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/08 05:31:55 UTC
[GitHub] [hive] pvary commented on pull request #1221: HIVE-23786: HMS server side filter with Ranger
pvary commented on pull request #1221:
URL: https://github.com/apache/hive/pull/1221#issuecomment-655295871
I have done a first sweeping review. A few asks:
* Beware of HMS API changes
* Check for memory consumption
* Check for performance
* Use checkstyle format check
As I am not too familiar with Ranger, please find a reviewer on that regard as well please.
Thanks for the patch. We really need these checks on HMS side as well.
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org