You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/22 17:14:27 UTC

[GitHub] [zookeeper] coder-chenzhi opened a new pull request #1464: ZOOKEEPER-3942 move traceMask calculation logic into the trace log guard

coder-chenzhi opened a new pull request #1464:
URL: https://github.com/apache/zookeeper/pull/1464


   Similar to ZOOKEEPER-3708 and ZOOKEEPER-3728 in `Learner`,  I found four cases where `traceMask` calculation logic are out of trace log guard in `LearnerHandler`, `PrepRequestProcessor`, and `ReadOnlyRequestProcessor`. The `traceMask` only matters if trace is enabled, so move the associated code into the logging guard.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] asfgit closed pull request #1464: ZOOKEEPER-3942 move traceMask calculation logic into the trace log guard

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1464:
URL: https://github.com/apache/zookeeper/pull/1464


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on pull request #1464: ZOOKEEPER-3942 move traceMask calculation logic into the trace log guard

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1464:
URL: https://github.com/apache/zookeeper/pull/1464#issuecomment-766147975


   @coder-chenzhi 
   Thanks for your contribution. Very sorry for our late:)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] coder-chenzhi commented on pull request #1464: ZOOKEEPER-3942 move traceMask calculation logic into the trace log guard

Posted by GitBox <gi...@apache.org>.
coder-chenzhi commented on pull request #1464:
URL: https://github.com/apache/zookeeper/pull/1464#issuecomment-755296672


   Hi, @maoling . Could you find other reviewers to review this patch?  I think the patch is easy to review. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org