[GitHub] [accumulo] ctubbsii commented on a change in pull request #1096: Remove usage of Generated annotation from thrift code.

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1096: Remove usage of Generated annotation from thrift code.
URL: https://github.com/apache/accumulo/pull/1096#discussion_r275975506
 
 

 ##########
 File path: core/src/main/scripts/generate-thrift.sh
 ##########
 @@ -78,6 +78,9 @@ done
 find $BUILD_DIR/gen-java -name '*.java' -exec grep -Zl '^public class ' {} + | xargs -0 sed -i -e 's/^[}]$/  private static void unusedMethod() {}\
 }/'
 
+# Remove usage of the javax.annotation.Generated because its no longer present in Java 11
+find $BUILD_DIR/gen-java -name "*.java" | xargs sed -i -e '/[@]javax[.]annotation[.]Generated.*/d'
 
 Review comment:
   There's actually a thrift generator flag to omit these.
   
   Instead of: `java:generated_annotations=undated`, we should use `java:generated_annotations=suppress`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services