You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2015/11/13 22:40:11 UTC

[jira] [Commented] (CALCITE-964) Rename "timezone" connection property to "timeZone"

    [ https://issues.apache.org/jira/browse/CALCITE-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004759#comment-15004759 ] 

Julian Hyde commented on CALCITE-964:
-------------------------------------

[~elserj] Can you please review my proposed fix in https://github.com/julianhyde/calcite/commit/1e4cbfbac756b1ba8056f9c6285f252a921ce31d.

> Rename "timezone" connection property to "timeZone"
> ---------------------------------------------------
>
>                 Key: CALCITE-964
>                 URL: https://issues.apache.org/jira/browse/CALCITE-964
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> Rename "timezone" connection property to "timeZone", to be consistent with java.util.TimeZone (two words in camel case). Also rename CalciteConnectionProperty.TIMEZONE and BuiltInConnectionProperty.TIMEZONE to TIME_ZONE.
> ConnectionConfig.timeZone() is already OK.
> Connect string properties are matched case-insensitively, and so "jdbc:calcite:timezone=gmt+3" will continue to work. So will "timeZone", "TIME_ZONE", "TIMEZONE".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)