You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/19 16:04:04 UTC
[GitHub] [netbeans] mbien opened a new pull request, #4817: migrate even more CI jobs
mbien opened a new pull request, #4817:
URL: https://github.com/apache/netbeans/pull/4817
continues the great migration (#4431).
wip
* second attempt to migrate the groovy jobs (first: #4105). I have the suspicion that the tests can't run on anything > JDK 8. The test setup on travis is just testing the same thing three times in a matrix. This [comment](https://github.com/apache/netbeans/pull/2708#issuecomment-774009452) made a similar observation. -> going to leave the groovy tests on 8 for now.
* migrated harness, ergonomics, nb modules and LSP tests and merged them into a single job.
lets do a test run. once we know the timings we can decide which jobs/steps need to be label-activated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1308019051
@matthiasblaesing connector lib update didn't help unfortunately:
```
[junit] Wed Nov 09 00:13:04 UTC 2022 WARN: Establishing SSL connection without server's identity verification is not recommended. According to MySQL 5.5.45+, 5.6.26+ and 5.7.6+ requirements SSL connection must be established by default if explicit option isn't set. For compliance with existing applications not using SSL the verifyServerCertificate property is set to 'false'. You need either to explicitly disable SSL by setting useSSL=false, or set useSSL=true and provide truststore for server certificate verification.
```
and
```
[junit] Caused by: javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled or cipher suites are inappropriate)
[junit] at java.base/sun.security.ssl.HandshakeContext.<init>(HandshakeContext.java:170)
[junit] at java.base/sun.security.ssl.ClientHandshakeContext.<init>(ClientHandshakeContext.java:103)
[junit] at java.base/sun.security.ssl.TransportContext.kickstart(TransportContext.java:222)
[junit] at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:449)
[junit] at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:427)
[junit] at com.mysql.jdbc.ExportControlled.transformSocketToSSLSocket(ExportControlled.java:186)
```
i have still a local backup of the commit which updates the tests in case we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1307829426
@mbien valid point - I'll get it done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1309216826
@mbien another old unittest dependency, the previous one was in `db.mysql`, this one is in `db.metadata.model`. #4953 has a corresponding fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien merged PR #4817:
URL: https://github.com/apache/netbeans/pull/4817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1014735005
##########
.github/workflows/main.yml:
##########
@@ -91,6 +109,13 @@ jobs:
key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
restore-keys: ${{ runner.os }}-
+ - name: Setup Gradle Daemon to run on JDK 11
+ if: ${{ matrix.java > 18 }}
+ run: |
+ mkdir -p ~/.gradle
+ #uses a preinstalled JDK 11 from the runner
+ echo "org.gradle.java.home=$JAVA_HOME_11_X64" >> ~/.gradle/gradle.properties
Review Comment:
this allows us to build on JDK 19+ too.
Its unclear why building locally on JDK 19 works perfectly fine without having to configure the daemon to run somewhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1307828499
@matthiasblaesing great will do. We can probably do this in a separate PR even before this here is integrated, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1304391574
it turned out that the LSP tests are the endboss of this endeavor.
Going to leave them out of this PR. It is be the last job which remains on travis for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1014648330
##########
.github/workflows/main.yml:
##########
@@ -1547,12 +1632,6 @@ jobs:
java-version: ${{ matrix.java }}
distribution: 'zulu'
- - uses: actions/cache@v3
- with:
- path: ~/Library/Caches/Homebrew
- key: ${{ runner.os }}-homebrew
- restore-keys: ${{ runner.os }}-homebrew
-
Review Comment:
the mac job cached about 3.4 GB of files without actually having to do that. It installed ant with brew (few lines later), but ant is already on the system (even in the same version).
```
Run brew install ant
Warning: ant 1.10.12 is already installed and up-to-date.
To reinstall 1.10.12, run:
brew reinstall ant
```
Maybe I am missing something obvious here (the ant tests don't use brew for anything, right?), but I think we can simply remove caching on the mac :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1307814317
Instead of changing the code in `db.mysql` let's please update the dependency of connector/j. I updated it to the current version 8.0.31 and unittests run clean. The real fix was somewhere between 8.0.17 and 8.0.20, but as newest runs on JDK 8-19 I think this is better. It is also low risk, as this is a pure unittest depdency.
The size of the changeset is purely created by update license file.
[db.mysql.bump.connectorj.patch.zip](https://github.com/apache/netbeans/files/9965156/db.mysql.bump.connectorj.patch.zip)
The "real" change is this (yes connector/j switch groupIds):
```patch
matthias@enterprise:~/src/netbeans$ git diff ide/db.mysql/external/binaries-list ide/db.mysql/nbproject/project.properties
diff --git a/ide/db.mysql/external/binaries-list b/ide/db.mysql/external/binaries-list
index a0c50ecfccc5..323f53cc6e24 100644
--- a/ide/db.mysql/external/binaries-list
+++ b/ide/db.mysql/external/binaries-list
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
-53DA6AFDC5F7B45CAAA5BC3627028B2041A36CEE mysql:mysql-connector-java:8.0.17
+3FD5850719D7E82D50705D34CC6A0037FAB5731F com.mysql:mysql-connector-j:8.0.31
diff --git a/ide/db.mysql/nbproject/project.properties b/ide/db.mysql/nbproject/project.properties
index 61702569949e..4668ce59ff94 100644
--- a/ide/db.mysql/nbproject/project.properties
+++ b/ide/db.mysql/nbproject/project.properties
@@ -18,4 +18,4 @@ javac.source=1.8
javac.compilerargs=-Xlint -Xlint:-serial
spec.version.base=0.47.0
-test.unit.cp.extra=external/mysql-connector-java-8.0.17.jar
+test.unit.cp.extra=external/mysql-connector-j-8.0.31.jar
matthias@enterprise:~/src/netbeans$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1290623964
yes I saw the mail too. Good that we started so early - the hardest part is done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1009636258
##########
.github/workflows/main.yml:
##########
@@ -1814,6 +2002,42 @@ jobs:
if: failure()
with:
paths: "./*/*/build/test/*/results/*.xml"
+
+
+ graalvm-test:
+ name: GraalVM Test ${{ matrix.graal }}
+ needs: base-build
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ graal: [ '20.3.0', '21.1.0' ]
+ steps:
+
+ - name: Set up JDK 8
+ uses: actions/setup-java@v3
+ with:
+ java-version: 8
+ distribution: 'zulu'
+
+ - name: Setup Xvfb
+ run: |
+ echo "DISPLAY=:99.0" >> $GITHUB_ENV
+ Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar --zstd -xf build.tar.zst
+
+ - name: Setup Env
+ run: echo "GRAAL_VERSION=${{ matrix.graal }}" >> $GITHUB_ENV
+
+ - name: nbbuild/travis/scripting.sh
+ run: nbbuild/travis/scripting.sh
Review Comment:
or: i don't touch the script, i simply replicate it in the gh yaml. Since the graalvm setup can be probably mapped to the java setup action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1300699584
From what I recall / can see, that's a job to check that the source zip of just the platform builds correctly. As we've just had the conversation on dropping releasing `netbeans-platform-xx-source.zip` from the release artefacts in NB16, it might be OK to drop that test. Although it might also be useful still? cc @ebarboni
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1013432850
##########
.github/workflows/main.yml:
##########
@@ -1814,6 +2002,42 @@ jobs:
if: failure()
with:
paths: "./*/*/build/test/*/results/*.xml"
+
+
+ graalvm-test:
+ name: GraalVM Test ${{ matrix.graal }}
+ needs: base-build
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ graal: [ '20.3.0', '21.1.0' ]
+ steps:
+
+ - name: Set up JDK 8
+ uses: actions/setup-java@v3
+ with:
+ java-version: 8
+ distribution: 'zulu'
+
+ - name: Setup Xvfb
+ run: |
+ echo "DISPLAY=:99.0" >> $GITHUB_ENV
+ Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar --zstd -xf build.tar.zst
+
+ - name: Setup Env
+ run: echo "GRAAL_VERSION=${{ matrix.graal }}" >> $GITHUB_ENV
+
+ - name: nbbuild/travis/scripting.sh
+ run: nbbuild/travis/scripting.sh
Review Comment:
I ended up fully converting the script to steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1309218824
> @mbien another old unittest dependency, the previous one was in `db.mysql`, this one is in `db.metadata.model`. #4953 has a corresponding fix.
oh wow good eyes! I didn't even notice that this is a different one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1304394424
I don't quite like that "Build all tests" is as step of the primary job, this doubles its runtime and delays everything else. Probably going to put that in its own job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1319188599
@neilcsmith-net @eirikbakke (or anybody else)
Can we skip the gen-sigtests step sometimes? Add it to a label or something similar? Check-sigtests is important but i believe the gen step is just useful for regression testing.
https://github.com/apache/netbeans/actions/runs/3491385341/jobs/5844321726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1336027235
@neilcsmith-net @lkishalmi @ebarboni @sdedic would now be a good time to merge this? Is most of the release work done? I also see master is green again.. so this might be good timing.
Reminder that travis will be gone in less than a month. We should have CI working before that so that we can fix things if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1325763569
LSP job sometimes errors with:
```
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec
[junit]
[junit] Testcase: org.netbeans.modules.java.lsp.server.protocol.ServerTest:testDidOpenPreservesLines: Caused an ERROR
[junit] Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
[junit] junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
[junit] at java.util.Vector.forEach(Vector.java:1277)
[junit] at java.util.Vector.forEach(Vector.java:1277)
[junit]
[junit]
[junit] Test org.netbeans.modules.java.lsp.server.protocol.ServerTest FAILED (timeout)
```
but the retry script can brute force through it - so its all good.
Thanks to @sdedic for fixing the nb-javac task issue in #4975 (#4921 for context). I also changed all jobs which use multiple JDKs to set them up right at the beginning of the job for getting consistent timestamps of JDK tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1008940349
##########
.github/workflows/main.yml:
##########
@@ -107,6 +113,66 @@ jobs:
retention-days: 1
if-no-files-found: error
+ - name: Build all Tests
+ if: env.test_tests == 'true' && success()
+ run: ant -quiet -Dcluster.config=release test -Dtest.includes=NoTestsJustBuild
+
+
+ java-cluster:
+ name: Build Java Cluster on JDK ${{ matrix.java }}
+ if: contains(github.event.pull_request.labels.*.name, 'ci:no-build') == false
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ '11' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Setup Xvfb
+ if: ${{ matrix.java != '20-ea' }} # see #4299
+ run: |
+ echo "DISPLAY=:99.0" >> $GITHUB_ENV
+ Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
+
+ - name: Checkout ${{ github.ref }} ( ${{ github.sha }} )
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: false
+
+ - name: Caching dependencies
+ uses: actions/cache@v3
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Build Java Cluster
+ run: |
+ ant $OPTS -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false clean
+ ant $OPTS -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false build
+
+ - name: Set up JDK 8
+ uses: actions/setup-java@v3
+ with:
+ java-version: 8
+ distribution: 'zulu'
+
+ - name: java/java.lsp.server
+ run: ant $OPTS -Dcluster.config=java -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -f java/java.lsp.server test
Review Comment:
I am having difficulties migrating the `java/java.lsp.server` job. Its an unreliable job on travis which makes it difficult to figure out what is wrong even if it reliably fails, since at least half of the failures are the sporadic failures.
I tried to replicate similar conditions as on travis, I even detached it from the pipeline and build the `java` cluster just for this test on JDK 11, then switch to 8 and run the test.
this error looks suspicious since I couldn't find it in sporadic local failures so far (I hope this isn't just yet another sporadic one):
```
[junit] Oct 30, 2022 10:30:08 PM org.eclipse.lsp4j.jsonrpc.RemoteEndpoint fallbackResponseError
[junit] SEVERE: Internal error: java.lang.NoClassDefFoundError: org/netbeans/modules/java/lsp/server/htmlui/$JsCallbacks$
[junit] java.util.concurrent.CompletionException: java.lang.NoClassDefFoundError: org/netbeans/modules/java/lsp/server/htmlui/$JsCallbacks$
[junit] at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273)
[junit] at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280)
[junit] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1606)
[junit] at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
[junit] at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
[junit] at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
[junit] at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)
[junit] Caused by: java.lang.NoClassDefFoundError: org/netbeans/modules/java/lsp/server/htmlui/$JsCallbacks$
[junit] at org.netbeans.modules.java.lsp.server.htmlui.Buttons.createButton0(Buttons.java)
[junit] at org.netbeans.modules.java.lsp.server.ui.AbstractLspHtmlViewer.createButton(AbstractLspHtmlViewer.java:56)
[junit] at org.netbeans.modules.java.lsp.server.ui.AbstractLspHtmlViewer.createButton(AbstractLspHtmlViewer.java:41)
[junit] at org.netbeans.modules.htmlui.Buttons.createButton(Buttons.java:150)
[junit] at org.netbeans.modules.htmlui.Buttons.buttons(Buttons.java:107)
[junit] at org.netbeans.modules.htmlui.HTMLDialogBase$1AcceptAndInit.initializeButtons(HTMLDialogBase.java:86)
[junit] at org.netbeans.modules.htmlui.HTMLDialogBase$1AcceptAndInit.call(HTMLDialogBase.java:78)
[junit] at org.netbeans.modules.htmlui.HTMLDialogBase$1AcceptAndInit.call(HTMLDialogBase.java:46)
[junit] at org.netbeans.spi.htmlui.HTMLViewerSpi$Context.onPageLoad(HTMLViewerSpi.java:168)
[junit] at org.netbeans.modules.java.lsp.server.ui.MockHtmlViewer.lambda$load$0(MockHtmlViewer.java:52)
[junit] at net.java.html.BrwsrCtx$1Wrap.run(BrwsrCtx.java:120)
[junit] at net.java.html.BrwsrCtx.execute(BrwsrCtx.java:129)
[junit] at org.netbeans.modules.java.lsp.server.ui.MockHtmlViewer.load(MockHtmlViewer.java:49)
[junit] at org.netbeans.modules.java.lsp.server.ui.MockHtmlViewer.component(MockHtmlViewer.java:73)
[junit] at org.netbeans.modules.java.lsp.server.ui.MockHtmlViewer.component(MockHtmlViewer.java:40)
[junit] at org.netbeans.modules.htmlui.HtmlPair.component(HtmlPair.java:64)
[junit] at org.netbeans.modules.htmlui.HTMLDialogBase.create(HTMLDialogBase.java:96)
[junit] at org.netbeans.api.htmlui.HTMLDialog$Builder.show(HTMLDialog.java:227)
[junit] at org.netbeans.modules.java.lsp.server.refactoring.Pages.showMoveMembersUI(Pages.java:63)
[junit] at org.netbeans.modules.java.lsp.server.refactoring.MoveRefactoring.lambda$null$0(MoveRefactoring.java:164)
[junit] at org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:504)
[junit] at org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
[junit] at org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:132)
[junit] at org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:116)
[junit] at org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
[junit] at org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
[junit] at org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
[junit] at org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
[junit] at org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
[junit] at org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
[junit] at org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
[junit] at org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:83)
[junit] at org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:454)
[junit] at org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:425)
[junit] at org.netbeans.modules.java.lsp.server.refactoring.MoveRefactoring.lambda$processCommand$1(MoveRefactoring.java:156)
[junit] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)
[junit] ... 4 more
```
@sdedic does this error look familiar to you or is this a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1009618281
##########
nbbuild/travis/scripting.sh:
##########
@@ -41,24 +41,24 @@ $GRAALVM/bin/gu install ruby
JAVA_HOME=$GRAALVM
echo "ant -f platform/api.scripting/build.xml test"
-hide-logs.sh ant -f platform/api.scripting/build.xml test
+ant -f platform/api.scripting/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f ide/libs.graalsdk/build.xml test"
-hide-logs.sh ant -f ide/libs.graalsdk/build.xml test
+ant -f ide/libs.graalsdk/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f platform/core.network/build.xml test"
-hide-logs.sh ant -f platform/core.network/build.xml test
+ant -f platform/core.network/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f webcommon/libs.graaljs/build.xml test"
-hide-logs.sh ant -f webcommon/libs.graaljs/build.xml test
+ant -f webcommon/libs.graaljs/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f profiler/profiler.oql/build.xml test"
-hide-logs.sh ant -f profiler/profiler.oql/build.xml test
+ant -f profiler/profiler.oql/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f java/nashorn.execution/build.xml test"
-hide-logs.sh ant -f java/nashorn.execution/build.xml test
+ant -f java/nashorn.execution/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f java/debugger.jpda.truffle/build.xml test"
-hide-logs.sh ant -f java/debugger.jpda.truffle/build.xml test
+ant -f java/debugger.jpda.truffle/build.xml test
Review Comment:
i would like to take this whole script and convert this into gh actions
this would map directly to steps. Makes it easier to see what fails (log split per step), allows to add retry per test etc. Disadvantage is that it makes it less portable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1009618281
##########
nbbuild/travis/scripting.sh:
##########
@@ -41,24 +41,24 @@ $GRAALVM/bin/gu install ruby
JAVA_HOME=$GRAALVM
echo "ant -f platform/api.scripting/build.xml test"
-hide-logs.sh ant -f platform/api.scripting/build.xml test
+ant -f platform/api.scripting/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f ide/libs.graalsdk/build.xml test"
-hide-logs.sh ant -f ide/libs.graalsdk/build.xml test
+ant -f ide/libs.graalsdk/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f platform/core.network/build.xml test"
-hide-logs.sh ant -f platform/core.network/build.xml test
+ant -f platform/core.network/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f webcommon/libs.graaljs/build.xml test"
-hide-logs.sh ant -f webcommon/libs.graaljs/build.xml test
+ant -f webcommon/libs.graaljs/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f profiler/profiler.oql/build.xml test"
-hide-logs.sh ant -f profiler/profiler.oql/build.xml test
+ant -f profiler/profiler.oql/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f java/nashorn.execution/build.xml test"
-hide-logs.sh ant -f java/nashorn.execution/build.xml test
+ant -f java/nashorn.execution/build.xml test
JAVA_HOME=$GRAALVM
echo "ant -f java/debugger.jpda.truffle/build.xml test"
-hide-logs.sh ant -f java/debugger.jpda.truffle/build.xml test
+ant -f java/debugger.jpda.truffle/build.xml test
Review Comment:
i would like to take this whole script and convert this into gh actions
this would map directly to steps. Makes it easier to see what fails (log split per step), allows to add retry per test etc. Disadvantage is that it makes it less portable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1009630360
##########
.github/workflows/main.yml:
##########
@@ -1814,6 +2002,42 @@ jobs:
if: failure()
with:
paths: "./*/*/build/test/*/results/*.xml"
+
+
+ graalvm-test:
+ name: GraalVM Test ${{ matrix.graal }}
+ needs: base-build
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ graal: [ '20.3.0', '21.1.0' ]
+ steps:
+
+ - name: Set up JDK 8
+ uses: actions/setup-java@v3
+ with:
+ java-version: 8
+ distribution: 'zulu'
+
+ - name: Setup Xvfb
+ run: |
+ echo "DISPLAY=:99.0" >> $GITHUB_ENV
+ Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar --zstd -xf build.tar.zst
+
+ - name: Setup Env
+ run: echo "GRAAL_VERSION=${{ matrix.graal }}" >> $GITHUB_ENV
+
+ - name: nbbuild/travis/scripting.sh
+ run: nbbuild/travis/scripting.sh
Review Comment:
i thought about converting `scripting.sh` into gh yaml
this would map directly to steps. Makes it easier to see what fails (log split per step), allows to add retry per test if needed etc. (context: the job was fairly unreliable on travis)
Disadvantage is that it makes it somewhat less portable + if someone likes to run this locally it wouldn't be a single script anymore. I could leave the setup part in the script and call it, while converting the test execution to steps?
@neilcsmith-net @matthiasblaesing @jtulach what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1318052764
@ebarboni does jenkins need any scripts which are in the `nbbuild/travis` folder? `ant.sh` for example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1337020209
I would say go for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1009630360
##########
.github/workflows/main.yml:
##########
@@ -1814,6 +2002,42 @@ jobs:
if: failure()
with:
paths: "./*/*/build/test/*/results/*.xml"
+
+
+ graalvm-test:
+ name: GraalVM Test ${{ matrix.graal }}
+ needs: base-build
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ graal: [ '20.3.0', '21.1.0' ]
+ steps:
+
+ - name: Set up JDK 8
+ uses: actions/setup-java@v3
+ with:
+ java-version: 8
+ distribution: 'zulu'
+
+ - name: Setup Xvfb
+ run: |
+ echo "DISPLAY=:99.0" >> $GITHUB_ENV
+ Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar --zstd -xf build.tar.zst
+
+ - name: Setup Env
+ run: echo "GRAAL_VERSION=${{ matrix.graal }}" >> $GITHUB_ENV
+
+ - name: nbbuild/travis/scripting.sh
+ run: nbbuild/travis/scripting.sh
Review Comment:
i thought about converting scripting.sh into gh yaml
this would map directly to steps. Makes it easier to see what fails (log split per step), allows to add retry per test if needed etc. (context: the job was fairly unreliable on travis)
Disadvantage is that it makes it somewhat less portable + if someone likes to run this locally it wouldn't be a single script anymore. I could leave the setup part in the script and call it, while converting the test execution to steps?
@neilcsmith-net @matthiasblaesing @jtulach what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1014674020
##########
.github/workflows/main.yml:
##########
@@ -1814,6 +2072,118 @@ jobs:
if: failure()
with:
paths: "./*/*/build/test/*/results/*.xml"
+
+
+ graalvm-test:
+ name: GraalVM ${{ matrix.graal }} Tests
+ # equals env.test_graalvm == 'true'
+ if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') || contains(github.event.pull_request.labels.*.name, 'ci:all-tests') || github.event_name != 'pull_request' }}
+ needs: base-build
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ graal: [ '20.3.0', '21.1.0' ]
+ fail-fast: false
+
+ steps:
+ - name: Setup Xvfb
+ run: |
+ echo "DISPLAY=:99.0" >> $GITHUB_ENV
+ Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar --zstd -xf build.tar.zst
+
+ - name: Setup GraalVM
+ run: |
+ URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-${{ matrix.graal }}/graalvm-ce-java8-linux-amd64-${{ matrix.graal }}.tar.gz
+ curl -L $URL | tar -xz
+ GRAALVM=`pwd`/graalvm-ce-java8-${{ matrix.graal }}
+ echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
+
+ - name: Setup GraalVM Languages
+ run: |
+ $JAVA_HOME/bin/gu install python
+ $JAVA_HOME/bin/gu install R
+ $JAVA_HOME/bin/gu install ruby
+
+ - name: platform/core.network
+ run: ant $OPTS -f platform/core.network test
+
+ - name: platform/api.scripting
+ run: ant $OPTS -f platform/api.scripting test
+
+ - name: ide/libs.graalsdk
+ run: ant $OPTS -f ide/libs.graalsdk test
+
+ - name: webcommon/libs.graaljs
+ run: ant $OPTS -f webcommon/libs.graaljs test
+
+ - name: profiler/profiler.oql
+ run: ant $OPTS -f profiler/profiler.oql test
+
+ - name: java/nashorn.execution
+ run: ant $OPTS -f java/nashorn.execution test
+
+ - name: java/debugger.jpda.truffle
+ run: ant $OPTS -f java/debugger.jpda.truffle test
Review Comment:
this one might need the retry wrapper. Going to add that on next update.
https://github.com/apache/netbeans/actions/runs/3400808308/jobs/5655578361#logs
edit: done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1319185454
@matthiasblaesing I noticed that you are sometimes providing dev builds for your PRs to make it easier to review. I added a label activated dev build step which can do the same (`ci:dev-build`). Would this be useful for you?
a test run is here (scroll down):
https://github.com/apache/netbeans/actions/runs/3491385341
retention time is set to 7 days. Its a zip in a zip but this is currently a github limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1009961890
##########
.github/workflows/main.yml:
##########
@@ -2078,7 +2078,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
- graal: [ '20.3.0', '21.1.0' ]
+ graal: [ '20.3.8', '21.3.3.1' ]
Review Comment:
bumped the GraalVM versions to latest update release. Should 22 be also in the matrix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1009961890
##########
.github/workflows/main.yml:
##########
@@ -2078,7 +2078,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
- graal: [ '20.3.0', '21.1.0' ]
+ graal: [ '20.3.8', '21.3.3.1' ]
Review Comment:
bumped the GraalVM versions to latest update release. Should 22 be also in the matrix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4817: migrate even more CI jobs
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1290203205
Well, this puts a timescale of end of year on all this - https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=Travis+Migrations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1300585916
https://github.com/apache/netbeans/blob/451a7ca25198baf37a9d361626aa4671dbb04f4a/.travis.yml#L45-L55
This is the last remaining travis job (yey!). Since the primary job builds all clusters on every single workflow run, do we still need an extra job for the platform? @jtulach @neilcsmith-net @matthiasblaesing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4817: CI: the final migration
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1014674020
##########
.github/workflows/main.yml:
##########
@@ -1814,6 +2072,118 @@ jobs:
if: failure()
with:
paths: "./*/*/build/test/*/results/*.xml"
+
+
+ graalvm-test:
+ name: GraalVM ${{ matrix.graal }} Tests
+ # equals env.test_graalvm == 'true'
+ if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') || contains(github.event.pull_request.labels.*.name, 'ci:all-tests') || github.event_name != 'pull_request' }}
+ needs: base-build
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ graal: [ '20.3.0', '21.1.0' ]
+ fail-fast: false
+
+ steps:
+ - name: Setup Xvfb
+ run: |
+ echo "DISPLAY=:99.0" >> $GITHUB_ENV
+ Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar --zstd -xf build.tar.zst
+
+ - name: Setup GraalVM
+ run: |
+ URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-${{ matrix.graal }}/graalvm-ce-java8-linux-amd64-${{ matrix.graal }}.tar.gz
+ curl -L $URL | tar -xz
+ GRAALVM=`pwd`/graalvm-ce-java8-${{ matrix.graal }}
+ echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
+
+ - name: Setup GraalVM Languages
+ run: |
+ $JAVA_HOME/bin/gu install python
+ $JAVA_HOME/bin/gu install R
+ $JAVA_HOME/bin/gu install ruby
+
+ - name: platform/core.network
+ run: ant $OPTS -f platform/core.network test
+
+ - name: platform/api.scripting
+ run: ant $OPTS -f platform/api.scripting test
+
+ - name: ide/libs.graalsdk
+ run: ant $OPTS -f ide/libs.graalsdk test
+
+ - name: webcommon/libs.graaljs
+ run: ant $OPTS -f webcommon/libs.graaljs test
+
+ - name: profiler/profiler.oql
+ run: ant $OPTS -f profiler/profiler.oql test
+
+ - name: java/nashorn.execution
+ run: ant $OPTS -f java/nashorn.execution test
+
+ - name: java/debugger.jpda.truffle
+ run: ant $OPTS -f java/debugger.jpda.truffle test
Review Comment:
this one might need the retry wrapper. Going to add that on next update.
https://github.com/apache/netbeans/actions/runs/3400808308/jobs/5655578361#logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists