You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2016/11/10 16:46:06 UTC
[GitHub] trafficserver pull request #1216: Localized version of Boost.String_Ref.
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1216
Localized version of Boost.String_Ref.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver amc-string-ref
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1216
----
commit cb7a2e2f3df2df866779e8161664d2a1d404a6be
Author: Alan M. Carroll <so...@yahoo-inc.com>
Date: 2016-11-10T16:42:31Z
Localized version of Boost.String_Ref.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1216: Localized version of Boost.String_Ref.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1216
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1092/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1216: Localized version of Boost.String_Ref.
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/1216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1216: Localized version of Boost.String_Ref.
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1216
A derivative of the Boost library has been adopted in to the standard library for C++17 making this forward compatible but ATS won't be able to depend on that for quite a while. Based on C++11 probably not until 2022 or so. Therefore I think it well worth the small effort to put this in now and clean it up later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1216: Localized version of Boost.String_Ref.
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1216
I've been working with this, because it was suggested as a replacement for `ts::ConstBuffer` which was standard (or would become so) rather than custom code. However, my experience so far is it is not a sufficiently rich API to be a reasonable replacement for `ts::ConstBuffer`. A primary use for the latter is token based parsing and that's noticeably more challenging with these variants of string references. Perhaps adding global overloaded functions to do the missing parts is the better approach?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1216: Localized version of Boost.String_Ref.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1216
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1199/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1216: Localized version of Boost.String_Ref.
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1216
Further work indicates that `string_ref` isn't going to be a suitable replacement for `ConstBuffer`. I will be taking a different approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---