You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/17 14:41:58 UTC
[GitHub] [incubator-druid] leventov commented on issue #7206: Add the
pull-request template
leventov commented on issue #7206: Add the pull-request template
URL: https://github.com/apache/incubator-druid/pull/7206#issuecomment-484119691
@jon-wei @gianm @clintropolis @jihoonson I've updated the PR template.
Regarding the concurrency checklist, I've created a two-level system with single line items + slightly extended (and linkable) descriptions. The [checklist](https://github.com/apache/incubator-druid/pull/7206/files#diff-cc3b00c0bd0af574809cf49526a13c10) added to the Druid repository contains all one-liners which link to the [general checklist](https://github.com/code-review-checklists/java-concurrency), plus three Druid-specific items (see the bottom of the file). If it will be needed to diverge wording of Druid's items from the general checklist's items, the extended description can be copied over to the Druid's checklist file with adjustments, and the link from the one-liners list is updated to point to the copied description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org