[jira] [Commented] (SLING-6976) ContentLoader.binaryFile() and ContentLoader.binaryResource() should try to derive mimetype from classpath resource rather than from target property name

["Stefan Seifert (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057416#comment-16057416 ] 

Stefan Seifert commented on SLING-6976:
---------------------------------------

the mime type is tried to derive from the path, not a property name.
this is useful if the binary ist stored with it's real name in the repository as nt:file, which is not uncommon. if its only an nt:resource it might be rather useless.
but the caller has the choice because the methods providing a mime type also exist as alternative.
as not necessarily all unit tests really need a correct mime type but rather any mime type it's may be totally okay setting the fallback mimetype if no explicit is given.

> ContentLoader.binaryFile() and ContentLoader.binaryResource() should try to derive mimetype from classpath resource rather than from target property name
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-6976
>                 URL: https://issues.apache.org/jira/browse/SLING-6976
>             Project: Sling
>          Issue Type: Bug
>          Components: Testing
>    Affects Versions: Testing Sling Mock 2.2.12
>            Reporter: Konrad Windszus
>
> Currently the {{ContentLoader.binaryFile}} tries to derive the mime type from the target property which should contain the binary (https://github.com/apache/sling/blob/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/loader/ContentLoader.java#L226). This is useless, as the property name almost never contains an extension from which a mimetype could be derived. Instead the first argument (namely {{classpathResource}} should be taken as basis to derive the mime type from).
> Currently in practically all cases the mime type will be set to the default value (https://github.com/apache/sling/blob/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/loader/ContentLoader.java#L466) which is {{application/octet-stream}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)