You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dtenedor (via GitHub)" <gi...@apache.org> on 2026/06/12 18:47:39 UTC
[PR] [SPARK-57328][SQL] Extract matchedIdentifier into a static, resolver-parameterized helper [spark]
dtenedor opened a new pull request, #56478:
URL: https://github.com/apache/spark/pull/56478
## What changes were proposed in this pull request?
This PR refactors the relation-identifier suffix-match logic (`matchedIdentifier`) out of the
`ResolveHints.ResolveJoinStrategyHints` rule and into a static, resolver-parameterized helper,
so the logic can be shared without depending on fixed-point rule state.
- Added a static `ResolveHints.matchedIdentifier(identInHint, identInQuery, resolver)` helper that
takes the `resolver: Resolver` (i.e. `(String, String) => Boolean`) as an explicit parameter.
- Moved the explanatory doc comment (describing the tail-match semantics and the catalog-independent
comparison) onto the static helper.
- `ResolveJoinStrategyHints` now keeps a thin private `matchedIdentifier` that delegates to the
static helper, passing its `resolver`.
Passing the `resolver` in explicitly gives both the fixed-point analyzer and the single-pass
resolver one source of truth for hint-to-relation matching, without either having to depend on the
other's rule state.
No behavior change: the helper body is identical to the original.
## How was this patch tested?
Existing join-hint resolution test coverage (e.g. join hint suites) pins the behavior; this is a
pure extraction with no functional change.
## Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57328][SQL] Extract matchedIdentifier into a static, resolver-parameterized helper [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #56478:
URL: https://github.com/apache/spark/pull/56478#issuecomment-4734544203
The single CI failure is flaky/unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57328][SQL] Extract matchedIdentifier into a static, resolver-parameterized helper [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor closed pull request #56478: [SPARK-57328][SQL] Extract matchedIdentifier into a static, resolver-parameterized helper
URL: https://github.com/apache/spark/pull/56478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57328][SQL] Extract matchedIdentifier into a static, resolver-parameterized helper [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #56478:
URL: https://github.com/apache/spark/pull/56478#issuecomment-4736735066
Thanks for review! Merging to master and 4.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org