[GitHub] spark pull request: [SPARK-3967] don’t redundantly overwrite exe...

[andrewor14 <gi...@git.apache.org>]

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2848#discussion_r19985577
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -412,6 +412,36 @@ private[spark] object Utils extends Logging {
       }
     
       /**
    +   * Download a file from @in to @tempFile, then move it to @destFile, checking whether @destFile
    +   * already exists, is equal to the downloaded file, and can be overwritten.
    +   */
    +  private def moveFile(url: String,
    +                       in: InputStream,
    +                       tempFile: File,
    +                       destFile: File,
    +                       fileOverwrite: Boolean): Unit = {
    --- End diff --
    
    style should be
    ```
    private def moveFile(
        url: String,
        ...
        fileOverwrite: Boolean): Unit = {
      ...
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org