You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2016/12/09 10:41:14 UTC

Review Request 54579: Refactor widget instance view on Dashboard

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54579/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19146
    https://issues.apache.org/jira/browse/AMBARI-19146


Repository: ambari


Description
-------

Refactor widget instance view on Dashboard


Diffs
-----

  ambari-web/app/styles/dashboard.less c170894 
  ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 3802e29 
  ambari-web/app/templates/main/dashboard/widgets/pie_chart.hbs 1b14503 
  ambari-web/app/templates/main/dashboard/widgets/simple_text.hbs 80967b9 
  ambari-web/app/views/main/dashboard/widget.js 495db2e 
  ambari-web/test/views/main/dashboard/widget_test.js 63da712 

Diff: https://reviews.apache.org/r/54579/diff/


Testing
-------

19874 tests complete (27 seconds)
155 tests pending


Thanks,

Andrii Tkach

Re: Review Request 54579: Refactor widget instance view on Dashboard

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54579/#review158665
-----------------------------------------------------------


Ship it!




Ship It!

- Aleksandr Kovalenko


On \u0414\u0435\u043a. 9, 2016, 10:41 \u0434.\u043f., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54579/
> -----------------------------------------------------------
> 
> (Updated \u0414\u0435\u043a. 9, 2016, 10:41 \u0434.\u043f.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19146
>     https://issues.apache.org/jira/browse/AMBARI-19146
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Refactor widget instance view on Dashboard
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/styles/dashboard.less c170894 
>   ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 3802e29 
>   ambari-web/app/templates/main/dashboard/widgets/pie_chart.hbs 1b14503 
>   ambari-web/app/templates/main/dashboard/widgets/simple_text.hbs 80967b9 
>   ambari-web/app/views/main/dashboard/widget.js 495db2e 
>   ambari-web/test/views/main/dashboard/widget_test.js 63da712 
> 
> Diff: https://reviews.apache.org/r/54579/diff/
> 
> 
> Testing
> -------
> 
> 19874 tests complete (27 seconds)
> 155 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>