You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/09/30 12:48:19 UTC

[GitHub] [iceberg] chenjunjiedada commented on a change in pull request #1532: MR: use encryption manager for input files

chenjunjiedada commented on a change in pull request #1532:
URL: https://github.com/apache/iceberg/pull/1532#discussion_r497481270



##########
File path: mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergSplit.java
##########
@@ -79,12 +86,36 @@ public void write(DataOutput out) throws IOException {
     byte[] data = SerializationUtil.serializeToBytes(this.task);
     out.writeInt(data.length);
     out.write(data);
+
+    byte[] ioData = SerializationUtil.serializeToBytes(io);

Review comment:
       @rdblue @rdsr , I saw your comments in #985 about remove customized serialization. Now the `IcebergSplit` implements `org.apache.hadoop.mapred.InputSplit` which extends writable. So I keep serialization implementation. Does this make sense to you?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org