You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "thiagoelg (via GitHub)" <gi...@apache.org> on 2026/05/18 18:07:51 UTC
[PR] NO-ISSUE: Use pom.xml template in maven-base so new Kogito version are propagated to Gradle modules [incubator-kie-tools]
thiagoelg opened a new pull request, #3588:
URL: https://github.com/apache/incubator-kie-tools/pull/3588
With the initial change in https://github.com/apache/incubator-kie-tools/pull/3541 I introduced the support for overriding the Kogito version without changing the pom.xml. This was enough for Maven-based modules, but it fails for Gradle-based modules, as Gradle can't override properties from transitive dependencies.
This change removes the maven-base pom.xml in favor of a pom.xml.template file. The install script creates the pom.xml from the pom.xml.template and replaces the Quarkus and Kogito versions in it.
The pom.xml is ignored by git, so any changes from forks are not propagated to PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use pom.xml template in maven-base so new Kogito version are propagated to Gradle modules [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on PR #3588:
URL: https://github.com/apache/incubator-kie-tools/pull/3588#issuecomment-4481309936
> How this is related with Gradle? @thiagoelg
For downstream packages that use Gradle, overriding the `version.org.kie.kogito` version is not sufficient, as POM resolution occurs before any Gradle processing. That means that the `version.org.kie.kogito` value in the kie-tools-maven-base pom.xml is used instead of Maven config overrides (via `-Dversion.org.kie-kogito`) or any other Gradle setting.
I get some error like this:
```
quarkusProdBaseRuntimeClasspathConfigurationCopy1
Could not parse POM ...
```
This suggests the Quarkus Gradle plugin resolves things before Gradle, and Gradle can't do anything about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use pom.xml template in maven-base so new Kogito version are propagated to Gradle modules [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3588:
URL: https://github.com/apache/incubator-kie-tools/pull/3588#discussion_r3261409990
##########
examples/process-security/docker-compose/pgadmin/pgpass:
##########
@@ -1,6 +1,3 @@
-postgres:5432:bamoe1:kie-user-1:kie-pass-1
-postgres:5432:bamoe2:kie-user-2:kie-pass-2
-postgres:5432:bamoe3:kie-user-3:kie-pass-3
Review Comment:
Not really, just some leftover I found from a while ago
##########
examples/process-security/docker-compose/pgadmin/pgpass:
##########
@@ -1,6 +1,3 @@
-postgres:5432:bamoe1:kie-user-1:kie-pass-1
-postgres:5432:bamoe2:kie-user-2:kie-pass-2
-postgres:5432:bamoe3:kie-user-3:kie-pass-3
Review Comment:
Not really, just some leftovers I found from a while ago
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use pom.xml template in maven-base so new Kogito version are propagated to Gradle modules [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3588:
URL: https://github.com/apache/incubator-kie-tools/pull/3588#discussion_r3261268513
##########
examples/process-security/docker-compose/pgadmin/pgpass:
##########
@@ -1,6 +1,3 @@
-postgres:5432:bamoe1:kie-user-1:kie-pass-1
-postgres:5432:bamoe2:kie-user-2:kie-pass-2
-postgres:5432:bamoe3:kie-user-3:kie-pass-3
Review Comment:
@thiagoelg Is this related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use pom.xml template in maven-base so new Kogito version are propagated to Gradle modules [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg merged PR #3588:
URL: https://github.com/apache/incubator-kie-tools/pull/3588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org