You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/05 18:50:02 UTC

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4464: remove access methods of Filter and make field pub.

andygrove commented on code in PR #4464:
URL: https://github.com/apache/arrow-datafusion/pull/4464#discussion_r1039961568


##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1193,9 +1193,9 @@ pub struct SubqueryAlias {
 #[derive(Clone)]
 pub struct Filter {
     /// The predicate expression, which must have Boolean type.
-    predicate: Expr,
+    pub predicate: Expr,

Review Comment:
   > I think this would allow side-stepping the schema validation in try_new? I don't know how important this is
   
   Yes, the motivation for the current design (introduced in https://github.com/apache/arrow-datafusion/pull/3796) was to prevent invalid filters from being created.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org