You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/28 02:57:06 UTC

[GitHub] [doris] Gabriel39 opened a new pull request, #11277: [feature-wip] (datetimev2) support window funnel and modify valid dat…

Gabriel39 opened a new pull request, #11277:
URL: https://github.com/apache/doris/pull/11277

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   ## Checklist(Required)
   
   1. Type of your changes:
       - [ ] Improvement
       - [ ] Fix
       - [ ] Feature-WIP
       - [ ] Feature
       - [ ] Doc
       - [ ] Refator
       - [ ] Others: 
   2. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   3. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   5. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   6. Are there any changes that cannot be rolled back:
       - [ ] Yes
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #11277: [feature-wip] (datetimev2) support window funnel and modify valid dat…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11277:
URL: https://github.com/apache/doris/pull/11277#issuecomment-1197635315

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] Gabriel39 commented on a diff in pull request #11277: [feature-wip] (datetimev2) support window funnel and modify valid dat…

Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #11277:
URL: https://github.com/apache/doris/pull/11277#discussion_r931748931


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -1388,6 +1388,19 @@ private void initAggregateBuiltins() {
                 "",
                 "",
                 true, false, true, true));
+        addBuiltin(AggregateFunction.createBuiltin(FunctionSet.WINDOW_FUNNEL,

Review Comment:
   Only `create_aggregate_function_window_funnel` is registered in function factory as a function creator. When we pass a window argument with date type, a function implement `AggregateFunctionWindowFunnel<DateV2Value<DateV2ValueType>, UInt32>` will be returned. So no extra things is registered



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] Gabriel39 commented on a diff in pull request #11277: [feature-wip] (datetimev2) support window funnel and modify valid dat…

Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #11277:
URL: https://github.com/apache/doris/pull/11277#discussion_r931743971


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -1388,6 +1388,19 @@ private void initAggregateBuiltins() {
                 "",
                 "",
                 true, false, true, true));
+        addBuiltin(AggregateFunction.createBuiltin(FunctionSet.WINDOW_FUNNEL,

Review Comment:
   `window_funnel` will be searched in `IS_NONSTRICT_SUPERTYPE_OF` mode so DATEV2 could be cast to DATETIMEV2 implicitly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #11277: [feature-wip] (datetimev2) support window funnel and modify valid dat…

Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #11277:
URL: https://github.com/apache/doris/pull/11277#discussion_r931746969


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -1388,6 +1388,19 @@ private void initAggregateBuiltins() {
                 "",
                 "",
                 true, false, true, true));
+        addBuiltin(AggregateFunction.createBuiltin(FunctionSet.WINDOW_FUNNEL,

Review Comment:
   Ok, then do `AggregateFunctionWindowFunnel<DateV2Value<DateV2ValueType>, UInt32>` still need to register? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #11277: [feature-wip] (datetimev2) support window funnel and modify valid dat…

Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #11277:
URL: https://github.com/apache/doris/pull/11277#discussion_r931743131


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -1388,6 +1388,19 @@ private void initAggregateBuiltins() {
                 "",
                 "",
                 true, false, true, true));
+        addBuiltin(AggregateFunction.createBuiltin(FunctionSet.WINDOW_FUNNEL,

Review Comment:
   Does we need add `DATEV2` override?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei merged pull request #11277: [feature-wip] (datetimev2) support window funnel and modify valid dat…

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11277:
URL: https://github.com/apache/doris/pull/11277


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #11277: [feature-wip] (datetimev2) support window funnel and modify valid dat…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11277:
URL: https://github.com/apache/doris/pull/11277#issuecomment-1197635292

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org