You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by alopresto <gi...@git.apache.org> on 2018/06/04 22:54:54 UTC
[GitHub] nifi pull request #2761: NIFI-5209 Removed secure hash functionality from Co...
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/2761
NIFI-5209 Removed secure hash functionality from ConfigEncryptionTool.
This feature was added to support external integration with Apache Ambari. Ambari developers then discovered a problem with the joint proposal and we built a different way to accomplish the goal. This behavior should be removed so it does not go in a release and need to be supported unnecessarily.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-5209
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2761
----
commit 51822b8569d21965c3cf91f7f1ae2758285adf44
Author: Andy LoPresto <al...@...>
Date: 2018-06-04T19:39:34Z
NIFI-5209 Removed secure hash functionality from ConfigEncryptionTool.
Removed relevant unit tests.
----
---
[GitHub] nifi issue #2761: NIFI-5209 Removed secure hash functionality from ConfigEnc...
Posted by thenatog <gi...@git.apache.org>.
Github user thenatog commented on the issue:
https://github.com/apache/nifi/pull/2761
Reviewing..
---
[GitHub] nifi issue #2761: NIFI-5209 Removed secure hash functionality from ConfigEnc...
Posted by thenatog <gi...@git.apache.org>.
Github user thenatog commented on the issue:
https://github.com/apache/nifi/pull/2761
Looks fine to me after looking at https://issues.apache.org/jira/browse/NIFI-4942, executed encrypting a properties file which worked and attempted to use the -z param which no longer works. Had a look through the code changes/remaining code and didn't see anything related to the hashing being left behind.
---
[GitHub] nifi pull request #2761: NIFI-5209 Removed secure hash functionality from Co...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2761
---