[GitHub] [daffodil] tuxji commented on a change in pull request #602: Use a hidden sonar properties file

[GitBox <gi...@apache.org>]

tuxji commented on a change in pull request #602:
URL: https://github.com/apache/daffodil/pull/602#discussion_r662402095



##########
File path: .github/workflows/main.yml
##########
@@ -166,3 +166,6 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          args: >
+            -Dproject.settings=.sonar-project.properties

Review comment:
       Do we really have to split the args line?  The YAML folded style is nice for multiple arguments since the indention in each line will be ignored and a line break will be inserted at the end, but I'd rather see one line when we have one argument:
   
   ```yml
             args: -Dproject.settings=.sonar-project.properties
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org