You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2012/05/05 22:48:13 UTC
svn commit: r1334498 -
/maven/wagon/trunk/wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java
Author: hboutemy
Date: Sat May 5 20:48:12 2012
New Revision: 1334498
URL: http://svn.apache.org/viewvc?rev=1334498&view=rev
Log:
use Java 5 constructs
Modified:
maven/wagon/trunk/wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java
Modified: maven/wagon/trunk/wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java
URL: http://svn.apache.org/viewvc/maven/wagon/trunk/wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java?rev=1334498&r1=1334497&r2=1334498&view=diff
==============================================================================
--- maven/wagon/trunk/wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java (original)
+++ maven/wagon/trunk/wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java Sat May 5 20:48:12 2012
@@ -51,7 +51,6 @@ import java.io.File;
import java.io.IOException;
import java.text.DecimalFormat;
import java.util.ArrayList;
-import java.util.Iterator;
import java.util.List;
import java.util.Random;
import java.util.Stack;
@@ -61,7 +60,7 @@ import java.util.Stack;
* <p/>
* TODO it probably creates problems if the same wagon is used in two different SCM protocols, as instance variables can
* keep incorrect state.
- * TODO: For doing releases we either have to be able to add files with checking out the repository structure which may not be
+ * TODO: For doing releases, we either have to be able to add files with checking out the repository structure which may not be
* possible, or the checkout directory needs to be a constant. Doing releases won't scale if you have to checkout the
* whole repository structure in order to add 3 files.
*
@@ -445,7 +444,7 @@ public class ScmWagon
{
checkoutDirectory = createCheckoutDirectory();
- Stack stack = new Stack();
+ Stack<String> stack = new Stack<String>();
String target = targetName;
@@ -739,9 +738,8 @@ public class ScmWagon
List<String> files = new ArrayList<String>();
- for ( Iterator<ScmFile> it = result.getFiles().iterator(); it.hasNext(); )
+ for ( ScmFile f : result.getFiles() )
{
- ScmFile f = it.next();
files.add( f.getPath() );
}