You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/03 15:58:06 UTC

[GitHub] [incubator-nuttx] easonxiang commented on pull request #6983: compiler.h: Rename inline_function to always_inline_function

easonxiang commented on PR #6983:
URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1236149634

   > After more thought, it's wrong to change the macro to always_inline since if user use this in source code directly:
   > 
   > ```
   > __attribute__ ((always_inline))
   > ```
   > 
   > the marco expanse it to the invalid statement:
   > 
   > ```
   > __attribute__ ((__attribute__ ((always_inline, no_instrument_function))))
   > ```
   > 
   > So, it's better to keep in the current form. @easonxiang @pkarashchenko
   
   Yes, It's unavailable to define the same name with gcc key words. We can add some symbol, such as start with `_` or some similar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org