You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2017/11/09 18:53:06 UTC
[GitHub] spark pull request #19710: [SPARK-22485][BUILD] Use `exclude[Problem]` inste...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/19710
[SPARK-22485][BUILD] Use `exclude[Problem]` instead `excludePackage` in MiMa
## What changes were proposed in this pull request?
`excludePackage` is deprecated like the [following](https://github.com/lightbend/migration-manager/blob/master/core/src/main/scala/com/typesafe/tools/mima/core/Filters.scala#L33-L36). This PR uses `exclude[Problem](packageName + ".*")` instead.
```scala
@deprecated("Replace with ProblemFilters.exclude[Problem](\"my.package.*\")", "0.1.15")
def excludePackage(packageName: String): ProblemFilter = {
exclude[Problem](packageName + ".*")
}
```
## How was this patch tested?
Pass the Jenkins MiMa.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-22485
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19710.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19710
----
commit b46834dbeba54da68be52112425c784e04850140
Author: Dongjoon Hyun <do...@apache.org>
Date: 2017-11-09T18:49:45Z
[SPARK-22485][BUILD] Use `exclude[Problem]` instead `excludePackage` in MiMa
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19710: [SPARK-22485][BUILD] Use `exclude[Problem]` instead `exc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19710
**[Test build #83651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83651/testReport)** for PR 19710 at commit [`b46834d`](https://github.com/apache/spark/commit/b46834dbeba54da68be52112425c784e04850140).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19710: [SPARK-22485][BUILD] Use `exclude[Problem]` instead `exc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19710
**[Test build #83651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83651/testReport)** for PR 19710 at commit [`b46834d`](https://github.com/apache/spark/commit/b46834dbeba54da68be52112425c784e04850140).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19710: [SPARK-22485][BUILD] Use `exclude[Problem]` inste...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19710
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19710: [SPARK-22485][BUILD] Use `exclude[Problem]` instead `exc...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19710
@JoshRosen , @rxin , @srowen .
Could you review this PR about MiMa?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19710: [SPARK-22485][BUILD] Use `exclude[Problem]` instead `exc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19710
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19710: [SPARK-22485][BUILD] Use `exclude[Problem]` instead `exc...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19710
LGTM, merging to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19710: [SPARK-22485][BUILD] Use `exclude[Problem]` instead `exc...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19710
Thank you for review and merging, @vanzin .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19710: [SPARK-22485][BUILD] Use `exclude[Problem]` instead `exc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19710
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83651/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org