[GitHub] [doris] compasses commented on a diff in pull request #11144: [Optimize](page cache): bypass page cache during compaction

[GitBox <gi...@apache.org>]

compasses commented on code in PR #11144:
URL: https://github.com/apache/doris/pull/11144#discussion_r928192503


##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -88,7 +88,7 @@ Status BetaRowsetReader::init(RowsetReaderContext* read_context) {
     // load segments
     RETURN_NOT_OK(SegmentLoader::instance()->load_segments(
             _rowset, &_segment_cache_handle,
-            read_context->reader_type == ReaderType::READER_QUERY));

Review Comment:
   Yes, here just make sure it follow the option and to prevent misuse. Since the reader type default value is *READER_QUERY*.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org