You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/09/23 17:27:10 UTC
[kudu-CR] WIP KUDU-3371 [fs] make LBMCorruptor a base class
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20504
Change subject: WIP KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
WIP KUDU-3371 [fs] make LBMCorruptor a base class
Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager-test-util.cc
M src/kudu/fs/log_block_manager-test-util.h
M src/kudu/fs/log_block_manager-test.cc
4 files changed, 309 insertions(+), 172 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/20504/1
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20504
to look at the new patch set (#6).
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
KUDU-3371 [fs] make LBMCorruptor a base class
This patch has no functional changes, but just makes
LBMCorruptor a base class for the newly added
NativeMetadataLBMCorruptor.
NativeMetadataLBMCorruptor is a test util to corrupt various
on-disk data structures for the native metadata based log
block container LogBlockContainerNativeMeta.
This is a previous patch before introducing the RocksDB based
log block container, a new derived class from LBMCorruptor will
be introduced then.
Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager-test-util.cc
M src/kudu/fs/log_block_manager-test-util.h
M src/kudu/fs/log_block_manager-test.cc
4 files changed, 314 insertions(+), 185 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/20504/6
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Removed -Verified by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Oct 2023 03:06:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 2:
> Patch Set 1:
>
> (6 comments)
Done
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 24 Sep 2023 06:24:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
KUDU-3371 [fs] make LBMCorruptor a base class
This patch has no functional changes, but just makes
LBMCorruptor a base class for the newly added
NativeMetadataLBMCorruptor.
NativeMetadataLBMCorruptor is a test util to corrupt various
on-disk data structures for the native metadata based log
block container LogBlockContainerNativeMeta.
This is a previous patch before introducing the RocksDB based
log block container, a new derived class from LBMCorruptor will
be introduced then.
Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Reviewed-on: http://gerrit.cloudera.org:8080/20504
Reviewed-by: Yifan Zhang <ch...@163.com>
Tested-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager-test-util.cc
M src/kudu/fs/log_block_manager-test-util.h
M src/kudu/fs/log_block_manager-test.cc
4 files changed, 314 insertions(+), 185 deletions(-)
Approvals:
Yifan Zhang: Looks good to me, approved
Yingchun Lai: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 7
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Oct 2023 02:24:37 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.h
File src/kudu/fs/log_block_manager-test-util.h:
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.h@177
PS2, Line 177: // Use DataDirManager to access the Dir objects conveniently.
: DataDirManager* dd_manager_;
Seems this object is not so necessary to be introduced in the base class(at least in this patch's scope). Is it possible to include it only in a specific derived class? If not, maybe just include these changes in the relevant patch?
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc
File src/kudu/fs/log_block_manager-test-util.cc:
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@66
PS2, Line 66: max_malformed_types_ = 7;
nit: Could we initialize max_malformed_types_ in the .h file? It may be easier to find out why it should be 7.
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@233
PS2, Line 233: RETURN_NOT_OK(metadata_writer->Close());
: return Status::OK();
nit: Replace these with 'return metadata_writer->Close()'?
Same as other places.
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 07 Oct 2023 11:33:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Removed -Verified by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 10 Oct 2023 11:40:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 6:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc
File src/kudu/fs/log_block_manager-test-util.cc:
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@66
PS2, Line 66:
> nit: Could we move the definition for class NativeMetadataLBMCorruptor to
The implementation details is hided in .cpp designedly, the LBMCorruptor users are not needed to know the implamentation details. The motivation is keeping the .h files smaller, and they can still create LBMCorruptor object by LBMCorruptor:Create(..) freely.
http://gerrit.cloudera.org:8080/#/c/20504/5/src/kudu/fs/log_block_manager-test-util.cc
File src/kudu/fs/log_block_manager-test-util.cc:
http://gerrit.cloudera.org:8080/#/c/20504/5/src/kudu/fs/log_block_manager-test-util.cc@195
PS5, Line 195: // NOLINT(clang-analyzer-core.NonNullParamChecker)
> nit: Is this for avoiding lint-checking errors? Just curious why is it not
Yes, these NOLINT comments are aim to mute the Tidy Bot complaints in PS1.
http://gerrit.cloudera.org:8080/#/c/20504/5/src/kudu/fs/log_block_manager-test-util.cc@467
PS5, Line 467: n data_dirs_[rand_.Uniform(d
> I see some methods of the class NativeMetadataLBMCorruptor are spread over
Done
At the beginning, keep the modified code in the place would be convient for reviewer to compare code side-by-side :)
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Oct 2023 16:11:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 5: Code-Review+1
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 13 Oct 2023 08:48:02 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20504
to look at the new patch set (#5).
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
KUDU-3371 [fs] make LBMCorruptor a base class
This patch has no functional changes, but just makes
LBMCorruptor a base class for the newly added
NativeMetadataLBMCorruptor.
NativeMetadataLBMCorruptor is a test util to corrupt various
on-disk data structures for the native metadata based log
block container LogBlockContainerNativeMeta.
This is a previous patch before introducing the RocksDB based
log block container, a new derived class from LBMCorruptor will
be introduced then.
Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager-test-util.cc
M src/kudu/fs/log_block_manager-test-util.h
M src/kudu/fs/log_block_manager-test.cc
4 files changed, 287 insertions(+), 158 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/20504/5
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yifan Zhang, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20504
to look at the new patch set (#3).
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
KUDU-3371 [fs] make LBMCorruptor a base class
This patch has no functional changes, but just makes
LBMCorruptor a base class for the newly added
NativeMetadataLBMCorruptor.
NativeMetadataLBMCorruptor is a test util to corrupt various
on-disk data structures for the native metadata based log
block container LogBlockContainerNativeMeta.
This is a previous patch before introducing the RocksDB based
log block container, a new derived class from LBMCorruptor will
be introduced then.
Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager-test-util.cc
M src/kudu/fs/log_block_manager-test-util.h
M src/kudu/fs/log_block_manager-test.cc
4 files changed, 275 insertions(+), 152 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/20504/3
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Oct 2023 15:03:04 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc
File src/kudu/fs/log_block_manager-test-util.cc:
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@66
PS2, Line 66:
> Some comments have been added to the declaration of 'max_malformed_types_'
nit: Could we move the definition for class NativeMetadataLBMCorruptor to .h file?
http://gerrit.cloudera.org:8080/#/c/20504/5/src/kudu/fs/log_block_manager-test-util.cc
File src/kudu/fs/log_block_manager-test-util.cc:
http://gerrit.cloudera.org:8080/#/c/20504/5/src/kudu/fs/log_block_manager-test-util.cc@195
PS5, Line 195: // NOLINT(clang-analyzer-core.NonNullParamChecker)
nit: Is this for avoiding lint-checking errors? Just curious why is it not needed before?
http://gerrit.cloudera.org:8080/#/c/20504/5/src/kudu/fs/log_block_manager-test-util.cc@467
PS5, Line 467: NativeMetadataLBMCorruptor::
I see some methods of the class NativeMetadataLBMCorruptor are spread over methods of the base class LBMCorruptor. Should we put methods of the same class together?
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Oct 2023 07:18:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20504
to look at the new patch set (#4).
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
KUDU-3371 [fs] make LBMCorruptor a base class
This patch has no functional changes, but just makes
LBMCorruptor a base class for the newly added
NativeMetadataLBMCorruptor.
NativeMetadataLBMCorruptor is a test util to corrupt various
on-disk data structures for the native metadata based log
block container LogBlockContainerNativeMeta.
This is a previous patch before introducing the RocksDB based
log block container, a new derived class from LBMCorruptor will
be introduced then.
Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager-test-util.cc
M src/kudu/fs/log_block_manager-test-util.h
M src/kudu/fs/log_block_manager-test.cc
4 files changed, 289 insertions(+), 158 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/20504/4
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20504/3/src/kudu/fs/log_block_manager-test-util.h
File src/kudu/fs/log_block_manager-test-util.h:
http://gerrit.cloudera.org:8080/#/c/20504/3/src/kudu/fs/log_block_manager-test-util.h@155
PS3, Line 155: // by truncating one byte off the end of it.
: virtual Status AppendPartialRecord(const Container* c, BlockId block_id) = 0;
:
: // Appends a 'record' to the metadata part of container 'c'.
: virtual Status AppendMetadataRecord(const Container* c, const BlockRecordPB& record) = 0;
:
: // Corrupt the 'record' in
> What about consider uniting them into an enum structure ?
Thanks, good idea! Done
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Oct 2023 13:28:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 3: Verified+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20504/3/src/kudu/fs/log_block_manager-test-util.h
File src/kudu/fs/log_block_manager-test-util.h:
http://gerrit.cloudera.org:8080/#/c/20504/3/src/kudu/fs/log_block_manager-test-util.h@155
PS3, Line 155: // 'error_type' is in the following types of errors:
: // 0. No block offset.
: // 1. No block length.
: // 2. Negative block offset.
: // 3. Negative block length.
: // 4. Offset + length > data file size.
: // 5. Unrecognized op type.
What about consider uniting them into an enum structure ?
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Oct 2023 10:22:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20504
to look at the new patch set (#2).
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
KUDU-3371 [fs] make LBMCorruptor a base class
This patch has no functional changes, but just makes
LBMCorruptor a base class for the newly added
NativeMetadataLBMCorruptor.
NativeMetadataLBMCorruptor is a test util to corrupt various
on-disk data structures for the native metadata based log
block container LogBlockContainerNativeMeta.
This is a previous patch before introducing the RocksDB based
log block container, a new derived class from LBMCorruptor will
be introduced then.
Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager-test-util.cc
M src/kudu/fs/log_block_manager-test-util.h
M src/kudu/fs/log_block_manager-test.cc
4 files changed, 319 insertions(+), 176 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/20504/2
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.h
File src/kudu/fs/log_block_manager-test-util.h:
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.h@177
PS2, Line 177: // Initialized in Init().
: std::vector<Container> all_c
> Seems this object is not so necessary to be introduced in the base class(at
Done
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc
File src/kudu/fs/log_block_manager-test-util.cc:
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@66
PS2, Line 66:
> nit: Could we initialize max_malformed_types_ in the .h file? It may be eas
Some comments have been added to the declaration of 'max_malformed_types_' like "The value depends on the implementation of CreateMalformedRecord().", the readers could read the implementation of CreateMalformedRecord() to find out why it is 7 or other values.
Besides, the derive class NativeMetadataLBMCorruptor is hided in .cc file.
http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@233
PS2, Line 233:
: Status NativeMetadataL
> nit: Replace these with 'return metadata_writer->Close()'?
Done
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 10 Oct 2023 10:19:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5
Gerrit-Change-Number: 20504
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>