You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by michalklempa <gi...@git.apache.org> on 2016/02/05 13:51:16 UTC
[GitHub] nifi pull request: Fixed: ExecuteStreamCommand when expressions in...
GitHub user michalklempa opened a pull request:
https://github.com/apache/nifi/pull/205
Fixed: ExecuteStreamCommand when expressions in command arguments are…
… used, contents are not splitted by command separator
To reproduce the problem:
1. Create DataFlow
2. Add GenerateFlowFile processor, File Size: 10kB
3. Connect GenerateFlowFile -> success -> UpdateAttribute processor
4. In UpdateAttribute: create attribute optionalArgs with contents: "-c 5"
5. Connect UpdateAttribute -> success -> ExecuteStreamCommand
6. Configure ExecuteStreamCommand to execute Command Path: "ping", Command Arguments: "${optionalArgs} google.com", Argument Delimiter: " " (spacebar), Ignore STDIN: true, auto terminate: original
7. Connect ExecuteStreamCommand -> output stream - > LogAttribute to see some output. LogAttribute auto terminate: success, Log Level: error, Log Payload: true.
8. Run the flow.
Expected output:
1. ExecuteStreamCommand issues command ping with args: "-c", "5", "google.com"
Actual output:
1. ExecuteStreamCommand puts the "-c 5" into single arg for ProcessBuilder
This behavior is no problem for ping utility, but there are tools (like snmpwalk in my case), which are dumb enough not to parse command line arguments properly, when they are sent inproperly by ProcessBuilder.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michalklempa/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #205
----
commit 29da314d9327a880fe371e0c6c04d0777685b8b1
Author: Michal Klempa <mi...@gmail.com>
Date: 2016-02-05T12:28:15Z
Fixed: ExecuteStreamCommand when expressions in command arguments are used, contents are not splitted by command separator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Fixed: ExecuteStreamCommand when expressions in...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/205#issuecomment-180425351
Hello. Thank you for contributing. We will need to make sure there is an active JIRA for this PR and that the JIRA number is referenced in the commit message. Take a look here to help us with bringing the contrib in. https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide Also you can see on this page an automated Travis-CI build contrib check that occurs. It shows the build failed on all systems. It appears to be due to a line length violation. You can see that by looking here and scrolling down the page https://s3.amazonaws.com/archive.travis-ci.org/jobs/107227866/log.txt It says '[WARNING] src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java[305] (sizes) LineLength: Line is longer than 200 characters (found 212).'
Can you address the JIRA creation, commit message and the line length and push again so it will try the build again.
Thanks
Joe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Fixed: ExecuteStreamCommand when expressions in...
Posted by michalklempa <gi...@git.apache.org>.
Github user michalklempa closed the pull request at:
https://github.com/apache/nifi/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Fixed: ExecuteStreamCommand when expressions in...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/205#issuecomment-184677287
Thanks. Can you please close #205 in Github. Will take a look at #223 soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Fixed: ExecuteStreamCommand when expressions in...
Posted by michalklempa <gi...@git.apache.org>.
Github user michalklempa commented on the pull request:
https://github.com/apache/nifi/pull/205#issuecomment-184400660
Thank you for pointing the right direction.
Here is JIRA https://issues.apache.org/jira/browse/NIFI-1514 issue, new PR: https://github.com/apache/nifi/pull/223
You may close this PR as unmerged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---