[GitHub] [hive] sankarh commented on a change in pull request #788: HIVE-22234 : Hive replication fails with table already exist error when replicating from old version of hive.

[GitBox <gi...@apache.org>]

sankarh commented on a change in pull request #788: HIVE-22234 : Hive replication fails with table already exist error when replicating from old version of hive.
URL: https://github.com/apache/hive/pull/788#discussion_r328016580
 
 

 ##########
 File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
 ##########
 @@ -592,7 +592,7 @@ struct ColumnStatistics {
 2: required list<ColumnStatisticsObj> statsObj,
 3: optional bool isStatsCompliant, // Are the stats isolation-level-compliant with the
                                                       // the calling query?
-4: required string engine
+4: optional string engine
 
 Review comment:
   Why don't we keep it required and set the default engine (Hive) if metadata doesn't have it? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org