You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/02/01 02:23:35 UTC
[Impala-ASF-CR] IMPALA-11756: Disable auto analyze table triggered by Hive
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19464
Change subject: IMPALA-11756: Disable auto analyze table triggered by Hive
......................................................................
IMPALA-11756: Disable auto analyze table triggered by Hive
Hive will automatically recompute stats asynchronously after major
compactions. The tasks could fail if the table is removed, which usually
happens on our test tables. The failure could cause further failures on
other query-based compactions in the same session, and results in test
failures. See the analysis in the JIRA for an example.
We don't rely on Hive to recompute the stats. So we can disable this
feature to avoid the issue. This patch turns off
"hive.compactor.gather.stats" to disable it.
Tests:
- Ran exhaustive tests
Change-Id: Idc23100ae74d6cb07894053a26806e01258065ec
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/19464/1
--
To view, visit http://gerrit.cloudera.org:8080/19464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc23100ae74d6cb07894053a26806e01258065ec
Gerrit-Change-Number: 19464
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11756: Disable auto analyze table triggered by Hive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19464 )
Change subject: IMPALA-11756: Disable auto analyze table triggered by Hive
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9012/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc23100ae74d6cb07894053a26806e01258065ec
Gerrit-Change-Number: 19464
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 03:47:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11756: Disable auto analyze table triggered by Hive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19464 )
Change subject: IMPALA-11756: Disable auto analyze table triggered by Hive
......................................................................
IMPALA-11756: Disable auto analyze table triggered by Hive
Hive will automatically recompute stats asynchronously after major
compactions. The tasks could fail if the table is removed, which usually
happens on our test tables. The failure could cause further failures on
other query-based compactions in the same session, and results in test
failures. See the analysis in the JIRA for an example.
We don't rely on Hive to recompute the stats. So we can disable this
feature to avoid the issue. This patch turns off
"hive.compactor.gather.stats" to disable it.
Tests:
- Ran exhaustive tests
Change-Id: Idc23100ae74d6cb07894053a26806e01258065ec
Reviewed-on: http://gerrit.cloudera.org:8080/19464
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Riza Suminto: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc23100ae74d6cb07894053a26806e01258065ec
Gerrit-Change-Number: 19464
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11756: Disable auto analyze table triggered by Hive
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19464 )
Change subject: IMPALA-11756: Disable auto analyze table triggered by Hive
......................................................................
Patch Set 1: Code-Review+2
This looks OK to me.
--
To view, visit http://gerrit.cloudera.org:8080/19464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc23100ae74d6cb07894053a26806e01258065ec
Gerrit-Change-Number: 19464
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 03:45:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11756: Disable auto analyze table triggered by Hive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19464 )
Change subject: IMPALA-11756: Disable auto analyze table triggered by Hive
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc23100ae74d6cb07894053a26806e01258065ec
Gerrit-Change-Number: 19464
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 08:50:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11756: Disable auto analyze table triggered by Hive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19464 )
Change subject: IMPALA-11756: Disable auto analyze table triggered by Hive
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12279/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc23100ae74d6cb07894053a26806e01258065ec
Gerrit-Change-Number: 19464
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 02:43:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11756: Disable auto analyze table triggered by Hive
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19464 )
Change subject: IMPALA-11756: Disable auto analyze table triggered by Hive
......................................................................
Patch Set 1:
Thanks Riza for the quick review!
--
To view, visit http://gerrit.cloudera.org:8080/19464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc23100ae74d6cb07894053a26806e01258065ec
Gerrit-Change-Number: 19464
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 03:47:28 +0000
Gerrit-HasComments: No