You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lens.apache.org by am...@apache.org on 2016/08/19 04:22:45 UTC
lens git commit: LENS-1274 : Saved query table create failure
shouldn't stop lens server from starting
Repository: lens
Updated Branches:
refs/heads/master 603cd0fd0 -> 66bd58e4c
LENS-1274 : Saved query table create failure shouldn't stop lens server from starting
Project: http://git-wip-us.apache.org/repos/asf/lens/repo
Commit: http://git-wip-us.apache.org/repos/asf/lens/commit/66bd58e4
Tree: http://git-wip-us.apache.org/repos/asf/lens/tree/66bd58e4
Diff: http://git-wip-us.apache.org/repos/asf/lens/diff/66bd58e4
Branch: refs/heads/master
Commit: 66bd58e4c4354e88cb6af9dcfcb219fdaf9fdf2a
Parents: 603cd0f
Author: Rajat Khandelwal <pr...@apache.org>
Authored: Fri Aug 19 09:52:35 2016 +0530
Committer: Amareshwari Sriramadasu <am...@apache.org>
Committed: Fri Aug 19 09:52:35 2016 +0530
----------------------------------------------------------------------
.../org/apache/lens/server/query/save/SavedQueryDao.java | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lens/blob/66bd58e4/lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java b/lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
index 8762aff..4f072e2 100644
--- a/lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
+++ b/lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
@@ -45,7 +45,9 @@ import com.google.common.collect.Lists;
import com.google.common.collect.Sets;
import lombok.AllArgsConstructor;
import lombok.Data;
+import lombok.extern.slf4j.Slf4j;
+@Slf4j
public class SavedQueryDao {
private static final ObjectMapper MAPPER = new ObjectMapper();
@@ -65,12 +67,12 @@ public class SavedQueryDao {
SavedQueryDao(String dialectClass, QueryRunner runner)
throws LensException {
try {
- this.runner = runner;
this.dialect = (Dialect) Class.forName(dialectClass).newInstance();
- createSavedQueryTableIfNotExists();
- } catch (Exception e) {
+ } catch (InstantiationException | IllegalAccessException | ClassNotFoundException e) {
throw new LensException("Error initializing saved query dao", e);
}
+ this.runner = runner;
+ createSavedQueryTableIfNotExists();
}
/**
@@ -82,7 +84,7 @@ public class SavedQueryDao {
try {
runner.update(dialect.getCreateTableSyntax());
} catch (SQLException e) {
- throw new LensException("Cannot create saved query table!", e);
+ log.warn("Unable to create saved query table.");
}
}