You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/02/03 12:09:29 UTC

[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on a change in pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller

kingamarton commented on a change in pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227#discussion_r569361879



##########
File path: deployments/admission-controllers/scheduler/templates/server.yaml.template
##########
@@ -37,6 +37,13 @@ spec:
           ports:
           - containerPort: 9089
             name: webhook-api
+          resources:
+            limits:
+              cpu: "100m"
+              memory: 500Mi
+            requests:
+              cpu: "500m"
+              memory: 500Mi

Review comment:
       Can you please explain how you decided about this values?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org