You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2024/06/07 13:51:16 UTC
[PR] SOLR-17302: Convert /cluster filestore APIs to JAX-RS (reinstating after revert) [solr]
gerlowskija opened a new pull request, #2507:
URL: https://github.com/apache/solr/pull/2507
https://issues.apache.org/jira/browse/SOLR-17302
# Description
This PR brings back code originally introduced in PR #2470. The code was merged initially last week, but I noticed a bug in helping with [a different PR](https://github.com/apache/solr/pull/2471) and decided to revert until I had time to fix. (Some discussion of that [here](https://github.com/apache/solr/pull/2470)).
This PR reintroduces all of the code that was already reviewed and merged in #2470, while fixing the bug that caused reversion (an issue with our OAS code generation template).
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17302: Convert /cluster filestore APIs to JAX-RS (reinstating after revert) [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #2507:
URL: https://github.com/apache/solr/pull/2507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17302: Convert /cluster filestore APIs to JAX-RS (reinstating after revert) [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #2507:
URL: https://github.com/apache/solr/pull/2507#issuecomment-2154928517
With the exception of the `api.mustache` changes, everything in this PR has already been reviewed in #2470 , so I'm going to merge it fairly quickly so that it can be in the weekend's test runs. (I'm still happy to address feedback here, if anyone has comments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org