You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by noazark <gi...@git.apache.org> on 2014/10/01 22:53:40 UTC
[GitHub] thrift pull request: THRIFT-809 JavaScript required fields
GitHub user noazark opened a pull request:
https://github.com/apache/thrift/pull/232
THRIFT-809 JavaScript required fields
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/noazark/thrift thrift-809
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/232.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #232
----
commit 9a52eed5c371336c295a57cbb538c786531841dd
Author: Noah H. Smith <no...@batteredoats.com>
Date: 2014-10-01T17:14:37Z
THRIFT-809 JavaScript required fields
- Moved TPRotocolException into index.js, just like the other exceptions
- Compiler now generates exception handling for missing required fields
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-809 JavaScript required fields
Posted by henrique <gi...@git.apache.org>.
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/232#issuecomment-57777787
Please check https://travis-ci.org/apache/thrift/jobs/36811962#L4284
I think it's just a namespace problem.
Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-809 JavaScript required fields
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-809 JavaScript required fields
Posted by henrique <gi...@git.apache.org>.
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/232#issuecomment-58109612
hm... yes, you're right. Thanks for having a look.
I don't have time to debug this now but it also need to be fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-809 JavaScript required fields
Posted by noazark <gi...@git.apache.org>.
Github user noazark commented on the pull request:
https://github.com/apache/thrift/pull/232#issuecomment-58058863
Ahh, well the problem is not from my branch after all. See: https://travis-ci.org/apache/thrift/jobs/36996719#L4277
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-809 JavaScript required fields
Posted by noazark <gi...@git.apache.org>.
Github user noazark commented on the pull request:
https://github.com/apache/thrift/pull/232#issuecomment-58058114
I'm not sure if I understand the problem. It looks like the failure occurs here (last line):
```js
ThriftTest.Xception = function(args) {
this.errorCode = null;
this.message = null;
if (args) {
if (args.errorCode !== undefined) {
this.errorCode = args.errorCode;
}
if (args.message !== undefined) {
this.message = args.message;
}
}
};
Thrift.inherits(ThriftTest.Xception, Thrift.TException); // Line 871, ReferenceError: Can't find variable: Thrift
```
To my eyes the problem is that the Thrift global is not loaded at this point, but that seems weird. Any ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---