[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #18161: Modify static site web pages

[GitBox <gi...@apache.org>]

connorgoggins commented on a change in pull request #18161:
URL: https://github.com/apache/incubator-mxnet/pull/18161#discussion_r414927954



##########
File path: docs/static_site/src/_includes/get_started/linux/julia/build-from-source.md
##########
@@ -1,2 +1,2 @@
-Refer to the [Julia section of the MXNet Ubuntu installation guide](/get_started/ubuntu_setup#install-the-mxnet-package-for-julia).
+Refer to the [Julia section of the MXNet Ubuntu installation guide](/get_started/ubuntu_setup.html#install-the-mxnet-package-for-julia).

Review comment:
       These routes are actually valid - no need to add `.html`. To get them to work as they do in production, enable the `modrewrite` extension in your `httpd` configuration and run your webserver with `httpd`. [Here](https://www.digitalocean.com/community/tutorials/how-to-rewrite-urls-with-mod_rewrite-for-apache-on-ubuntu-16-04) is a good guide for doing this on Ubuntu.

##########
File path: docs/static_site/src/_includes/get_started/linux/python/cpu/docker.md
##########
@@ -40,4 +40,4 @@ REPOSITORY TAG IMAGE ID CREATED SIZE
 mxnet/python 1.3.0_cpu_mkl deaf9bf61d29 4 days ago 678 MB
 {% endhighlight %}
 
-**Step 4** <a href="get_started/validate_mxnet">Validate the installation</a>.
\ No newline at end of file
+**Step 4** <a href="/get_started/validate_mxnet.html">Validate the installation</a>.

Review comment:
       Routing config also applies here.

##########
File path: docs/static_site/src/_includes/get_started/linux/python/gpu/build-from-source.md
##########
@@ -1 +1 @@
-To build from source, refer to the [MXNet Ubuntu installation guide]({{'/get_started/ubuntu_setup' | relative_url}}).
+To build from source, refer to the [MXNet Ubuntu installation guide](/get_started/ubuntu_setup.html).

Review comment:
       Same here.

##########
File path: docs/static_site/src/_includes/get_started/windows/perl/perl.md
##########
@@ -1 +1 @@
-Refer to the [Perl section of the MXNet Windows installation guide](/get_started/windows_setup.html#install-the-mxnet-package-for-perl).
\ No newline at end of file
+MXNet-Perl for Windows is not yet available.

Review comment:
       Should be `MXNet Perl API for Windows`.

##########
File path: docs/static_site/src/_includes/get_started/macos/clojure/cpu.md
##########
@@ -1,8 +1,4 @@
-
-You can use the Maven packages defined in the following dependency to include MXNet in
-your Clojure project. To maximize leverage, the Clojure package has been built on the existing Scala
-package. Please refer to the [MXNet-Scala setup guide](scala_setup.html) for a detailed set
-of instructions to help you with the setup process that is required to use the Clojure dependency.
+Please refer to the [MXNet-Clojure setup guide](https://github.com/apache/incubator-mxnet/tree/master/contrib/clojure-package) for a detailed set of instructions to help you with the setup process that is required to use the Clojure dependency.

Review comment:
       Nice addition!

##########
File path: docs/static_site/src/_includes/get_started/windows/python/cpu/build-from-source.md
##########
@@ -1 +1 @@
-Refer to the [MXNet Windows installation guide](/get_started/windows_setup.html)
\ No newline at end of file
+To build from source, refer to the [MXNet Windows installation guide](/get_started/windows_setup.html).

Review comment:
       Great addition :)

##########
File path: docs/static_site/src/_includes/get_started/linux/scala/cpu.md
##########
@@ -1,5 +1,5 @@
 You can use the Maven packages defined in the following dependency to include MXNet in your Scala
-project. Please refer to the [MXNet-Scala setup guide]({{'/get_started/scala_setup'|relative_url}}) for
+project. Please refer to the [MXNet-Scala setup guide](/get_started/scala_setup.html) for

Review comment:
       Same here.

##########
File path: docs/static_site/src/_includes/get_started/macos/python/cpu/docker.md
##########
@@ -32,4 +32,4 @@ REPOSITORY TAG IMAGE ID CREATED SIZE
 mxnet/python 1.3.0_cpu_mkl deaf9bf61d29 4 days ago 678 MB
 {% endhighlight %}
 
-**Step 4** <a href="get_started/validate_mxnet">Validate the installation</a>.
\ No newline at end of file
+**Step 4** <a href="/get_started/validate_mxnet.html">Validate the installation</a>.

Review comment:
       Same here.

##########
File path: docs/static_site/src/pages/api/julia/index.md
##########
@@ -35,5 +35,6 @@ computing and the state-of-art deep learning to Julia.
   and apply them to tasks such as image classification and data science challenges.
 
 ## Installation
-* [Ubuntu installation guide]({{'/get_started/ubuntu_setup' | relative_url}})
-* Mac / Windows guides are not available (contributions welcome!)
+* [Ubuntu installation guide]({{'/get_started/ubuntu_setup.html'|relative_url}})

Review comment:
       Same here (+ several more on other files, wherever `.html` is added without changing the base route).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org