[CODE] fix Qt4/Kde4 detection in configure (was: [code] build on Linux 64 bits (Fedora 15))

[Ariel Constenla-Haile <ar...@gmail.com>]

Hi there,

On Thu, Sep 01, 2011 at 06:25:04PM -0300, Ariel Constenla-Haile wrote:
> * enabling KDE 4, moc can't be found:
> 
> checking for Qt4 headers... /usr/include
> checking for Qt4 libraries... /usr/lib64
> checking for moc... no
> configure: error: Qt Meta Object Compiler not found.  Please specify
> the root of your Qt installation by exporting QT4DIR before running "configure".
> 
> exporting QT4DIR=/usr/lib64/qt4 does not help. 
> Hard-coding MOC4="/usr/bin/moc-qt4" in configure allowed to move on until next error:
> 
> checking for moc... /usr/bin/moc-qt4
> checking for KDE4 headers... no
> configure: error: KDE4 headers not found.  Please specify the root of your KDE4 installation by exporting KDE4DIR before running "configure".
> 
> exporting KDE4DIR does not work, either. I didn't have time to look at these, so I simply disabled kde4.

in qt4 the moc binary is named moc-qt4 in most linux distros I checked
(Fedora, OpenSuse, Ubuntu), configure should try first to look for this
executable, and only the for moc.

On Fedora and other distros KDE includes happen to be in /usr/include/kde4
and KDE libraries in /usr/lib[64]/kde4/devel

The attached patch allows Qt4/KDE4 detection (tested only in Fedora 15).

Regards
-- 
Ariel Constenla-Haile
La Plata, Argentina

Re: [CODE] fix Qt4/Kde4 detection in configure

[Herbert Duerr <hd...@apache.org>]

On 04.10.2011 18:25, Ariel Constenla-Haile wrote:
 > in qt4 the moc binary is named moc-qt4 in most linux distros I checked
 > (Fedora, OpenSuse, Ubuntu), configure should try first to look for
 > this executable, and only the for moc.
> [...]
> The error is the "SMOC4" typo, it should be "$MOC4"

Thanks again! Pushed as
http://svn.apache.org/viewvc?rev=1179069&view=rev

I'll propose you to become a committer...

Herbert

Re: [CODE] fix Qt4/Kde4 detection in configure

[Ariel Constenla-Haile <ar...@gmail.com>]

Hi TJ

On Tue, Oct 04, 2011 at 11:57:44AM -0400, TJ Frazier wrote:
> +   MOC4="$MOCQT4"
> +   if test "SMOC4" = "no" ; then

ups thanks for pointing that out! (I sent an old patch, as the new diff
includes changes I made to build gstreamer)

The error is the "SMOC4" typo, it should be "$MOC4"


Regards
-- 
Ariel Constenla-Haile
La Plata, Argentina

Re: [CODE] fix Qt4/Kde4 detection in configure

[TJ Frazier <tj...@cfl.rr.com>]

+   MOC4="$MOCQT4"
+   if test "SMOC4" = "no" ; then

should that test be: s/S/$/ ?--
/tj/