You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/22 07:28:46 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #2584: esp32_wifi_adapter.c: file mode for open doesn't make sense for O_RDONLY

yamt opened a new pull request #2584:
URL: https://github.com/apache/incubator-nuttx/pull/2584


   ## Summary
   Don't bother to specify mode_t for open with O_RDONLY
   
   ## Impact
   
   ## Testing
   tested on esp32-devkitc


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2584: esp32_wifi_adapter.c: file mode for open doesn't make sense for O_RDONLY

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2584:
URL: https://github.com/apache/incubator-nuttx/pull/2584


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2584: esp32_wifi_adapter.c: file mode for open doesn't make sense for O_RDONLY

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2584:
URL: https://github.com/apache/incubator-nuttx/pull/2584#discussion_r547170882



##########
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##########
@@ -3111,7 +3111,7 @@ static int32_t esp_nvs_get_blob(uint32_t handle,
       return -1;
     }
 
-  fd = open(dir, O_RDONLY, NVS_FILE_MODE);
+  fd = open(dir, O_RDONLY);

Review comment:
       but the kernel code should call file_xxx instead




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org