You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/08 09:12:10 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request, #16988: [improve][ci] Skip unnecessary tests when there are only cpp/python related changes
RobertIndie opened a new pull request, #16988:
URL: https://github.com/apache/pulsar/pull/16988
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Currently, Java tests consume major CI resources. And it is not necessary to run all the tests for changes that are only on the C++ or python parts of the code. This PR skips unnecessary tests when there are only cpp/python changes. This can greatly increase the efficiency of CI when testing the C++/Python part of the code.
### Modifications
* Skip java unit tests, integration tests(the part only for java codes), go function tests.
* The system test is not skipped because there are some python function codes in that test.
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on a diff in pull request #16988: [improve][ci] Skip unnecessary tests when there are only cpp/python related changes
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on code in PR #16988:
URL: https://github.com/apache/pulsar/pull/16988#discussion_r940031377
##########
.github/changes-filter.yaml:
##########
@@ -10,3 +10,5 @@ docs:
- '**/*.md'
tests:
- added|modified: '**/src/test/java/**/*.java'
+cpp:
+ - 'pulsar-client-cpp/**'
Review Comment:
Yes, we will run them. This PR will not affect this part. It will only affect if the changes are all in the `pulsar-client-cpp/**`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16988: [improve][ci] Skip unnecessary tests when there are only cpp/python related changes
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #16988:
URL: https://github.com/apache/pulsar/pull/16988#discussion_r940023164
##########
.github/changes-filter.yaml:
##########
@@ -10,3 +10,5 @@ docs:
- '**/*.md'
tests:
- added|modified: '**/src/test/java/**/*.java'
+cpp:
+ - 'pulsar-client-cpp/**'
Review Comment:
We should also run the cpp test while the changes are introduced to the broker and proxy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #16988: [improve][ci] Skip unnecessary tests when there are only cpp/python related changes
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #16988:
URL: https://github.com/apache/pulsar/pull/16988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org