[GitHub] [mesos] cf-natali commented on a diff in pull request #446: Blkio isolator: handled missing CFQ statistics.

[GitBox <gi...@apache.org>]

cf-natali commented on code in PR #446:
URL: https://github.com/apache/mesos/pull/446#discussion_r1027270645


##########
src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp:
##########
@@ -107,226 +107,205 @@ Future<ResourceStatistics> BlkioSubsystemProcess::usage(
   CgroupInfo::Blkio::CFQ::Statistics totalCfqRecursive;
   CgroupInfo::Blkio::Throttling::Statistics totalThrottling;
 
-  // Get CFQ statistics.
+  // CFQ was removed from kernel 5.x, so be ready to handle missing statistics.
+
   Try<vector<cgroups::blkio::Value>> time = cfq::time(hierarchy, cgroup);

Review Comment:
   Sorry for the delay, I've been busy lately.
   
   It was removed from kernel 5.0: https://github.com/torvalds/linux/commit/f382fb0bcef4c37dc049e9f6963e3baf204d815c
   
   I've updated the change to explicitly change the kernel version - gitlab renders the diff in a sub-optimal way, but the change is actually very small (adding the version check).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org