You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aries.apache.org by ej...@apache.org on 2012/11/29 18:02:38 UTC
svn commit: r1415271 -
/aries/trunk/versioning/versioning-checker/src/main/java/org/apache/aries/versioning/utils/ClassDeclaration.java
Author: ejiang
Date: Thu Nov 29 17:02:37 2012
New Revision: 1415271
URL: http://svn.apache.org/viewvc?rev=1415271&view=rev
Log:
ARIES-975: semantic versioning tool serialisation id comparision is incorrect
Modified:
aries/trunk/versioning/versioning-checker/src/main/java/org/apache/aries/versioning/utils/ClassDeclaration.java
Modified: aries/trunk/versioning/versioning-checker/src/main/java/org/apache/aries/versioning/utils/ClassDeclaration.java
URL: http://svn.apache.org/viewvc/aries/trunk/versioning/versioning-checker/src/main/java/org/apache/aries/versioning/utils/ClassDeclaration.java?rev=1415271&r1=1415270&r2=1415271&view=diff
==============================================================================
--- aries/trunk/versioning/versioning-checker/src/main/java/org/apache/aries/versioning/utils/ClassDeclaration.java (original)
+++ aries/trunk/versioning/versioning-checker/src/main/java/org/apache/aries/versioning/utils/ClassDeclaration.java Thu Nov 29 17:02:37 2012
@@ -30,7 +30,6 @@ import java.util.Map;
import java.util.Set;
import org.objectweb.asm.ClassReader;
-import org.objectweb.asm.ClassVisitor;
import org.objectweb.asm.Type;
public class ClassDeclaration extends GenericDeclaration {
@@ -398,7 +397,7 @@ public class ClassDeclaration extends Ge
if ((!getAllSupers().contains(SemanticVersioningUtils.ENUM_CLASS) && (!old.getAllSupers().contains(SemanticVersioningUtils.ENUM_CLASS)))) {
Long oldValue = getSerialVersionUID(old);
Long curValue = getSerialVersionUID(this);
- if ((oldValue != curValue)) {
+ if ((oldValue.longValue() != curValue.longValue())) {
reasons.add("The serializable class is no longer back compatible as the value of SerialVersionUID has changed from " + oldValue + " to " + curValue + ".");
}
}