You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/08/07 11:45:49 UTC
Review Request 61456: Create a topic to send alert_definitions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61456/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-21667
https://issues.apache.org/jira/browse/AMBARI-21667
Repository: ambari
Description
-------
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 6c1d29c
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 9507c9d
ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/Constants.py 17ed2be
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 85840d0
ambari-agent/src/main/python/ambari_agent/InitializerModule.py 6ef4a04
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b75b540
ambari-agent/src/main/python/ambari_agent/alerts/collector.py adc7f47
ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 803bdc6
ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1e32718
ambari-agent/src/main/python/ambari_agent/alerts/recovery_alert.py 3092a39
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 945a222
ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py d6624cc
ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/HostLevelParamsEventListener.py 5aee634
ambari-agent/src/main/python/ambari_agent/main.py 56962d3
ambari-agent/src/test/python/ambari_agent/BaseStompServerTestCase.py 5db53c8
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 88f1e69
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json PRE-CREATION
Diff: https://reviews.apache.org/r/61456/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 61456: Create a topic to send alert_definitions
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61456/
-----------------------------------------------------------
(Updated Aug. 8, 2017, 9:10 a.m.)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-21667
https://issues.apache.org/jira/browse/AMBARI-21667
Repository: ambari
Description (updated)
-------
.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 6c1d29c
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 9507c9d
ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/Constants.py 17ed2be
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 85840d0
ambari-agent/src/main/python/ambari_agent/InitializerModule.py 6ef4a04
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b75b540
ambari-agent/src/main/python/ambari_agent/alerts/collector.py adc7f47
ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 803bdc6
ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1e32718
ambari-agent/src/main/python/ambari_agent/alerts/recovery_alert.py 3092a39
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 945a222
ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py d6624cc
ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/HostLevelParamsEventListener.py 5aee634
ambari-agent/src/main/python/ambari_agent/main.py 56962d3
ambari-agent/src/test/python/ambari_agent/BaseStompServerTestCase.py 5db53c8
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 88f1e69
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json PRE-CREATION
Diff: https://reviews.apache.org/r/61456/diff/2/
Changes: https://reviews.apache.org/r/61456/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 61456: Create a topic to send alert_definitions
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61456/#review182285
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Aug. 7, 2017, 11:45 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61456/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 11:45 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-21667
> https://issues.apache.org/jira/browse/AMBARI-21667
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 6c1d29c
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 9507c9d
> ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/Constants.py 17ed2be
> ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 85840d0
> ambari-agent/src/main/python/ambari_agent/InitializerModule.py 6ef4a04
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b75b540
> ambari-agent/src/main/python/ambari_agent/alerts/collector.py adc7f47
> ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 803bdc6
> ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1e32718
> ambari-agent/src/main/python/ambari_agent/alerts/recovery_alert.py 3092a39
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 945a222
> ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py d6624cc
> ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/HostLevelParamsEventListener.py 5aee634
> ambari-agent/src/main/python/ambari_agent/main.py 56962d3
> ambari-agent/src/test/python/ambari_agent/BaseStompServerTestCase.py 5db53c8
> ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 88f1e69
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61456/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>