You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/08 05:12:07 UTC

[GitHub] [ozone] ayushtkn commented on pull request #1665: HDDS-4554. numKey metrics goes negative after intermediate directory deletion.

ayushtkn commented on pull request #1665:
URL: https://github.com/apache/ozone/pull/1665#issuecomment-740379836


   Thanx Mukul for the fix.
    `TestOMDirectoryCreateRequest.testCreateDirectoryOMMetric` looks related, I think you need to increment the value there in the test to include the missing directories seems related, Apart changes looks reasonable
   
   >The key/file value is incremented because of metric increment in OmKeyCommitRequest
   
   Thnax for this I too spent around an hour trying to figure out the logic behind this yesterday. :-)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org