[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5612: boards/arm/stm32: Update adb configs

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5612:
URL: https://github.com/apache/incubator-nuttx/pull/5612#discussion_r814518549



##########
File path: boards/arm/stm32/stm32f103-minimum/configs/adb/defconfig
##########
@@ -40,13 +40,11 @@ CONFIG_FS_PROCFS_EXCLUDE_MOUNTS=y
 CONFIG_INIT_ENTRYPOINT="adbd_main"
 CONFIG_INIT_STACKSIZE=1024
 CONFIG_LIBUV=y
-CONFIG_LIBUV_PIPE=y
-CONFIG_LIBUV_STREAM=y
+CONFIG_LIBUV_UTILS_NONE=y

Review comment:
       remove, it's default

##########
File path: boards/arm/stm32/stm32f4discovery/configs/adb/defconfig
##########
@@ -44,21 +44,25 @@ CONFIG_INTELHEX_BINARY=y
 CONFIG_LIBC_ENVPATH=y
 CONFIG_LIBC_EXECFUNCS=y
 CONFIG_LIBUV=y
-CONFIG_LIBUV_PIPE=y
-CONFIG_LIBUV_STREAM=y
 CONFIG_MMCSD=y
+CONFIG_NET=y
+CONFIG_NETDEV_LATEINIT=y
+CONFIG_NET_SOCKOPTS=y
+CONFIG_NET_TCP_NO_STACK=y
+CONFIG_NET_UDP_NO_STACK=y

Review comment:
       remove NO_STACK?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org