You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/21 12:31:07 UTC
[GitHub] [dubbo-go-samples] PhilYue opened a new pull request #277: refactor: jsonrpc sample
PhilYue opened a new pull request #277:
URL: https://github.com/apache/dubbo-go-samples/pull/277
## Topic
- fix jsonrpc sample
## Desc.
- fix config of dubbogo.yml
- clean code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin merged pull request #277: refactor: jsonrpc sample
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #277:
URL: https://github.com/apache/dubbo-go-samples/pull/277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] justxuewei commented on a change in pull request #277: refactor: jsonrpc sample
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #277:
URL: https://github.com/apache/dubbo-go-samples/pull/277#discussion_r734456910
##########
File path: rpc/jsonrpc/go-client/conf/dubbogo.yml
##########
@@ -12,41 +12,23 @@ dubbo:
address: "127.0.0.1:2181"
Review comment:
remove quote
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #277: refactor: jsonrpc sample
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #277:
URL: https://github.com/apache/dubbo-go-samples/pull/277#discussion_r734462469
##########
File path: rpc/jsonrpc/go-client/conf/dubbogo.yml
##########
@@ -12,41 +12,23 @@ dubbo:
address: "127.0.0.1:2181"
Review comment:
I would fix this immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org