[GitHub] [incubator-doris] morningman commented on a change in pull request #2525: Unify the names of methods in `TabletManager` which do not require locks

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2525: Unify the names of methods in `TabletManager` which do not require locks
URL: https://github.com/apache/incubator-doris/pull/2525#discussion_r360843865
 
 

 ##########
 File path: be/src/olap/tablet_manager.h
 ##########
 @@ -149,55 +131,58 @@ class TabletManager {
     // Return OLAP_SUCCESS, if run ok
     //        OLAP_ERR_TABLE_INSERT_DUPLICATION_ERROR, if find duplication
     //        OLAP_ERR_NOT_INITED, if not inited
-    OLAPStatus _add_tablet_unlock(TTabletId tablet_id, SchemaHash schema_hash,
-                         const TabletSharedPtr& tablet, bool update_meta, bool force);
-    
-    OLAPStatus _add_tablet_to_map(TTabletId tablet_id, SchemaHash schema_hash,
-                                 const TabletSharedPtr& tablet, bool update_meta, 
-                                 bool keep_files, bool drop_old);
-    
-    void _build_tablet_stat();
-    bool _check_tablet_id_exist_unlock(TTabletId tablet_id);
-    OLAPStatus _create_inital_rowset(TabletSharedPtr tablet, const TCreateTabletReq& request);
-    
+    OLAPStatus _add_tablet_unlocked(TTabletId tablet_id, SchemaHash schema_hash,
 
 Review comment:
   I think you could add code guide for the tablet manager class, to let other developers know how to name a method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org