You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/26 06:10:16 UTC

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #4138: [Bug] [Spill To Disk] Fix Mem exceed bug in Sort Node when use multi spill operator

HappenLee commented on a change in pull request #4138:
URL: https://github.com/apache/incubator-doris/pull/4138#discussion_r477056049



##########
File path: be/src/runtime/spill_sorter.cc
##########
@@ -1242,7 +1242,7 @@ uint64_t SpillSorter::estimate_merge_mem(
 Status SpillSorter::merge_intermediate_runs() {
     int blocks_per_run = _has_var_len_slots ? 2 : 1;
     int max_runs_per_final_merge =
-            _block_mgr->available_allocated_buffers() / blocks_per_run;
+            _block_mgr->available_buffers(_block_mgr_client) / blocks_per_run;

Review comment:
       Hello, wuyufeng.
   This is client only use as BlockMgr Client.  
   Just keep the same with Impala `BufferedBlockMgr::Client* block_mgr_client_`
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org