[jira] [Commented] (MAPREDUCE-6164) "mapreduce.reduce.shuffle.fetch.retry.timeout-ms" should be set to 3 minutes instead of 30 seconds by default to be consistent with other retry timeout

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525657#comment-14525657 ] 

Hadoop QA commented on MAPREDUCE-6164:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 39s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 29s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 41s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase the total number of release audit warnings. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 1  line(s) that end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | mapreduce tests |   1m 34s | Tests passed in hadoop-mapreduce-client-core. |
| | |  35m 55s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12681914/MAPREDUCE-6164.patch |
| Optional Tests | javadoc javac unit |
| git revision | trunk / e8d0ee5 |
| whitespace | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5622/artifact/patchprocess/whitespace.txt |
| hadoop-mapreduce-client-core test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5622/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt |
| Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5622/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5622/console |


This message was automatically generated.

> "mapreduce.reduce.shuffle.fetch.retry.timeout-ms" should be set to 3 minutes instead of 30 seconds by default to be consistent with other retry timeout 
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6164
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6164
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: MAPREDUCE-6164.patch
>
>
> In MAPREDUCE-5891, we are adding retry logic to MAPREDUCE shuffle stage for fetcher can be survival during NM downtime (with shuffle service down as well). In many places, we are setting the default timeout to be 3 minutes (connection timeout, etc.) to tolerant possible more time for NM down, but we are making "mapreduce.reduce.shuffle.fetch.retry.timeout-ms" to be 30 seconds which is not consistent here. We should change this to 180 seconds. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)